Open
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
requested changes
Apr 19, 2026
| {{- crate::icons::IconCircleInfo.render_solid(false, false, "") -}} | ||
| <span class="alert-text">{{- alert|safe -}}</span> | ||
| </div> | ||
| <script type="text/javascript">{%- include "alert.js" -%}</script> |
Member
There was a problem hiding this comment.
we probably should expose alert.js similar to menu.js as separate ( cacheable ) asset:
<script async src="/-/static/menu.js?{{ build_slug }}"></script>
syphar
requested changes
Apr 21, 2026
Member
Author
|
For this part, you're the expert so whatever you think is better. |
Member
a partial loaded via separate URL. So we have a "static" part (script / html), which is always the same, can be cached as long as the page itself (forever). And a "dynamic" part loaded from a separate URL (like the version lists), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a POC to add support for alerts. For now, it always generates an alert so you can give it a try. Even without JS, you can hide the alert. If JS is enabled when closing the alert, it will store the information and not show this alert again from this point.