-
Notifications
You must be signed in to change notification settings - Fork 223
Add base for alert support #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GuillaumeGomez
wants to merge
1
commit into
rust-lang:main
Choose a base branch
from
GuillaumeGomez:alert-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| (function() { | ||
| const alertCheckbox = document.getElementById("docsrs-alert-input"); | ||
| alertCheckbox.onchange = () => { | ||
| // If the user clicks on the "close button", we save this info in their local storage. | ||
| window.localStorage.setItem("hide-alert-id", alertCheckbox.getAttribute("data-id")); | ||
| }; | ||
|
|
||
| const info = window.localStorage.getItem("hide-alert-id"); | ||
| if (info !== null) { | ||
| const alertId = alertCheckbox.getAttribute("data-id"); | ||
| // If the user already "closed" the alert, we don't show it anymore. | ||
| if (alertId === info) { | ||
| alertCheckbox.checked = true; | ||
| } | ||
| } | ||
| })(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,3 +123,15 @@ | |
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| {%- if let Some((alert, alert_id)) = crate::get_alert() -%} | ||
|
syphar marked this conversation as resolved.
|
||
| <input type="checkbox" id="docsrs-alert-input" data-id={{alert_id|safe}}> | ||
| <label id="docsrs-alert-hide" for="docsrs-alert-input" title="Close alert message"> | ||
| {{- crate::icons::IconXmark.render_solid(false, false, "") -}} | ||
| </label> | ||
| <div id="docsrs-alert"> | ||
| {{- crate::icons::IconCircleInfo.render_solid(false, false, "") -}} | ||
| <span class="alert-text">{{- alert|safe -}}</span> | ||
| </div> | ||
| <script type="text/javascript">{%- include "alert.js" -%}</script> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we probably should expose <script async src="/-/static/menu.js?{{ build_slug }}"></script>
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. |
||
| {%- endif -%} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi:
I prepared parts of #3274 so we can include the alerts in that caching pipeline. When #3274 is merged etc I'm happy to update this PR to do it.
View changes since the review