feat(hal): add multiple register definitions (SYSCFG, XSPI, SID, SPI ENC, RTC)#13
Merged
Conversation
NanaHigh
commented
Jan 22, 2026
NanaHigh
commented
Member
- Add SYSCFG, XSPI, SID, SPI ENC, and RTC register definitions and implementations
- Fix naming issues and add missing test cases
- Fix code issues related to panic
- Fix some code issues related to panic. Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
luojia65
approved these changes
Jan 22, 2026
luojia65
left a comment
luojia65
left a comment
Member
There was a problem hiding this comment.
LGTM with minor suggestions. Nice job!
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| #[repr(u8)] | ||
| pub enum CsPolarity { | ||
| pub enum CsPol { |
Member
There was a problem hiding this comment.
Should we reuse embedded-hal::spi::Polarity and embedded-hal::spi::Phase for CsPol, Cpol and Cpha?
| /// Bit-mode CS polarity. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| #[repr(u8)] | ||
| pub enum BMCsPolarity { |
| /// Compare voltage selection. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | ||
| #[repr(u8)] | ||
| pub enum CmpVoltageSel { |
Member
There was a problem hiding this comment.
Suggested change
| pub enum CmpVoltageSel { | |
| pub enum CmpVoltage { |
Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
Signed-off-by: Chongbing Yu <nanahigh@openatom.club>
luojia65
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.