Skip to content

fix(setup): correct has_ext_modules method parameter name - #417

Merged
Trinkle23897 merged 1 commit into
sail-sg:mainfrom
hobostay:fix/setup-py-method-signature
May 22, 2026
Merged

fix(setup): correct has_ext_modules method parameter name#417
Trinkle23897 merged 1 commit into
sail-sg:mainfrom
hobostay:fix/setup-py-method-signature

Conversation

@hobostay

Copy link
Copy Markdown
Contributor

Summary

Fix the method parameter name from to in class.

Root Cause

In line 33:

The parameter should be to follow Python method conventions. This is inconsistent with defined just above it on line 29, and with the parent class .

While functionally equivalent (Python doesn't enforce parameter naming), this:

  • Confuses linters and type checkers (pylint R0201, mypy)
  • Is inconsistent with the rest of the codebase
  • Makes the code harder to read

Test plan

  • Verify still works
  • Verify wheel build process is unaffected

@hobostay
hobostay force-pushed the fix/setup-py-method-signature branch from 8c9081b to d4a72ee Compare May 22, 2026 15:13

@Trinkle23897 Trinkle23897 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trinkle23897
Trinkle23897 merged commit 8b8d973 into sail-sg:main May 22, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants