sap_software_download: Install required package on RHEL 10 - #78
Closed
berndfinger wants to merge 1 commit into
Closed
sap_software_download: Install required package on RHEL 10#78berndfinger wants to merge 1 commit into
berndfinger wants to merge 1 commit into
Conversation
Fixes issue sap-linuxlab#77. Signed-off-by: Bernd Finger <bfinger@redhat.com>
marcelmamula
requested changes
Jul 27, 2026
marcelmamula
left a comment
marcelmamula
left a comment
Contributor
There was a problem hiding this comment.
@berndfinger Please remove all vars changes except vars/main and RedHat_10.
We discussed it on friday that it is not required to touch all files, because our var loading concept is very flexible.
vars/mainis always loaded so__sap_software_download_additional_packages: []will be always set.- OS specific vars are loaded and if only RHEL10 contains additional package, then it will be replaced.
I use this everywhere, when I have SLES specific var changes and I leave other OS versions untouched. Example: https://github.com/sap-linuxlab/community.sap_install/tree/main/roles/sap_ha_install_hana_hsr/vars shows that all OS versions use same inputs, but SLES_15 has special vars changes that override defaults.
Member
Author
|
@marcelmamula Thanks for your comment. Closing in favor of a successor branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #77.