ScaleSim Accelergy Run Fixes

[arjun289]

Why?

The branch covering Accelergy integration is outdated. Also, there were a bunch of issues not allowing the runs to complete.

Additions

1. This branch has been forked from the scalesim-accelergy branch.
2. It has been rebased with the latest main branch.
3. New additions to accelergy components at scale-sim-v3/rundir-accelergy/accelergy_input/components. The reason is that earlier, the generated architecture.yaml file had primitive components that were not functioning properly. This fix adds new custom components that allow the Accelergy part to run.
4. Some modifications to scale-sim-v3/rundir-accelergy/preprocess.py to generate the architecture keys in the right order so it doesn't raise any errors. Earlier, the keys were sorted by yaml dump that would cause dependencies to not be in the right order.

fixes: #3

!! Note
One of the plugins being used here, https://github.com/Accelergy-Project/accelergy-aladdin-plug-in, also has a bug.
This will be fixed in the project but if you want to use it now. You can update the code in the plugin file.
/scale-sim-v3/accelergy/plugins/accelergy-aladdin-plug-in/aladdin_table.py line 276-80. The comparator_interface dicts need to have one more key-value pair as shown below

 comparator_interface = {
            "attributes": {"width": math.log2(float(depth))},
            "action_name": action_name,
            "arguments": interface["arguments"],  ## this line is missing
 }

The PR should allow you to run latest ScaleSim with Accelergy v3.

[zishenwan]

Hi @arjun289, thank you for the Accelergy integration pull request!

Before we can merge it into the main branch, we have a few suggestions to improve the code:

• Several new config files were added (e.g., configs/sweep_study/128_os.cfg, configs/sweep_study/256_os.cfg, configs/sweep_study/64_os.cfg). These seem to be for internal runs and don’t need to be part of the public repo.

• The accelergy scripts (e.g., rundir-accelergy/create_action_count.sh, rundir-accelergy/run_accelergy.sh) currently use absolute paths like /imec/other/csainfra/projectdata/singh16/hespas/scale-sim-v3/, please update these to relative paths.

• The topology MNK files (e.g., topologies/GEMM_mnk/NCF.csv, topologies/GEMM_mnk/gnmt.csv, topologies/GEMM_mnk/gpt2.csv, topologies/GEMM_mnk/transformer_partial.csv, topologies/GEMM_mnk/unet2d.csv) are missing trailing commas, please add the missing commas to these MNK files.

Once these are updated, feel free to resubmit the pull request. Thanks again for your contribution!

[louislecoeur]

Are these fixes supposed to run with accelergy V4? Or still the old V3? Thanks!

[arjun289]

All the changes are for v3. Accelergy v4 can't be used standalone without Timeloop.

[louislecoeur]

All the changes are for v3. Accelergy v4 can't be used standalone without Timeloop.

Thank you very much Arjun. I'm still struggling with installing this stack.
Two questions:

• can you provide the commit IDs that you use for Accelergy v3 and for its plugins (cacti, aladdin, tables?)
• did you post somewhere the updates to rundir-accelergy/create_action_count.sh and rundir-accelergy/run_accelergy.sh requested by zishenwan?

[ritikraj7]

Hi @arjun289 thanks a lot for opening the PR. This fixes the accelergy integration. I made some cleanups before the merge.

Thanks @zishenwan for the review!