refactor(networkcache): adding one more safety check#1468
Merged
Conversation
korgon
previously approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens NetworkCache.set() behavior to ensure the cache never grows beyond the configured maxSize when purging cannot free enough space (e.g., no purgeable entries remain).
Changes:
- Add a post-purge size check to skip caching when the new entry still won’t fit within
maxSize. - Emit a warning when an entry is skipped after unsuccessful purging.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
korgon
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.