Skip to content

refactor(networkcache): adding one more safety check #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
korgon merged 2 commits into from
Mar 18, 2026
Merged

refactor(networkcache): adding one more safety check #1468

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
387d27a
refactor(networkcache): adding one more safety check
chrisFrazier77 Mar 17, 2026
d0c4a08
test(networkcache): adding another test
chrisFrazier77 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/snap-client/src/Client/NetworkCache/NetworkCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,12 @@ export class NetworkCache {
currentSize = new Blob([JSON.stringify(this.memoryCache)], { endings: 'native' }).size / 1024;
}

// if we still can't fit the new object after purging, skip caching
if (currentSize + newObjectSize > this.config.maxSize) {
console.warn(`Unable to cache entry for key "${key}" without exceeding maxSize (${this.config.maxSize}KB), skipping cache`);
Comment thread
chrisFrazier77 marked this conversation as resolved.
return;
}
Comment thread
korgon marked this conversation as resolved.

// store cache in memory
this.memoryCache[key] = cacheObject;

Expand Down
Loading