Fix typed projection subprocess decoding on non-UTF-8 Windows locales#138
Merged
justinjoy merged 1 commit intoJun 22, 2026
Conversation
justinjoy
added a commit
that referenced
this pull request
Jun 22, 2026
Patch release with two correctness fixes since 0.4.0: - fix(merge): candidate dedup is now anchor-insensitive, aligning the dedup keys with the status-preservation keys (9624b5c). - fix(test): typed-projection subprocess tests decode child output as UTF-8, so they pass on non-UTF-8 host locales such as Windows CP949 (#138).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8".Why
On Windows locales where Python defaults to a non-UTF-8 encoding such as CP949,
subprocess.run(..., text=True)can fail to decode child process output that contains Korean/Unicode text. This caused three typed projection unit tests to fail even though the underlying behavior was correct.Validation
ruff check .pytest tests/unit/test_typed_projection.py -qwith default Windows localepytest -qwith default Windows locale