Skip to content

Fix typed projection subprocess decoding on non-UTF-8 Windows locales #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinjoy merged 1 commit into from
Jun 22, 2026
Merged

Fix typed projection subprocess decoding on non-UTF-8 Windows locales #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 18 additions & 33 deletions tests/unit/test_typed_projection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@
import pytest


def _run_child(command: list[str], *, env: dict[str, str]) -> subprocess.CompletedProcess[str]:
return subprocess.run(
command,
env=env,
capture_output=True,
text=True,
encoding="utf-8",
)


class TestTypedDecls:
def test_empty_specs_is_empty_string(self):
# Byte-identity gate (#116 invariant 1): nothing projectable -> "".
Expand Down Expand Up @@ -173,12 +183,7 @@ def test_end_to_end_threshold_inference(tmp_path: Path):
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(tmp_path)
env["KB_TOOLS"] = str(Path(common.__file__).resolve().parent)
proc = subprocess.run(
[sys.executable, "-c", _RUNNER],
env=env,
capture_output=True,
text=True,
)
proc = _run_child([sys.executable, "-c", _RUNNER], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
import json

Expand Down Expand Up @@ -236,12 +241,7 @@ def _run_logic_check(root: Path) -> str:
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(root)
tools_dir = Path(common.__file__).resolve().parent
proc = subprocess.run(
[sys.executable, str(tools_dir / "run_logic_check.py")],
env=env,
capture_output=True,
text=True,
)
proc = _run_child([sys.executable, str(tools_dir / "run_logic_check.py")], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
return (root / "facts" / "logic_report.txt").read_text(encoding="utf-8")

Expand Down Expand Up @@ -282,12 +282,7 @@ def _compile_facts(root: Path) -> subprocess.CompletedProcess[str]:
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(root)
tools_dir = Path(common.__file__).resolve().parent
return subprocess.run(
[sys.executable, str(tools_dir / "compile_facts.py")],
env=env,
capture_output=True,
text=True,
)
return _run_child([sys.executable, str(tools_dir / "compile_facts.py")], env=env)


def _build_superseded_kb(root: Path) -> None:
Expand Down Expand Up @@ -376,9 +371,7 @@ def _run_amount_kb(tmp_path: Path, units_clause: str) -> tuple[list[str], str]:
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(tmp_path)
env["KB_TOOLS"] = str(Path(common.__file__).resolve().parent)
proc = subprocess.run(
[sys.executable, "-c", _AMOUNT_RUNNER], env=env, capture_output=True, text=True
)
proc = _run_child([sys.executable, "-c", _AMOUNT_RUNNER], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
return json.loads(proc.stdout.strip().splitlines()[-1]), proc.stderr

Expand Down Expand Up @@ -420,9 +413,7 @@ def test_amount_out_of_int64_range_is_skipped(tmp_path: Path):
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(tmp_path)
env["KB_TOOLS"] = str(Path(common.__file__).resolve().parent)
proc = subprocess.run(
[sys.executable, "-c", _AMOUNT_RUNNER], env=env, capture_output=True, text=True
)
proc = _run_child([sys.executable, "-c", _AMOUNT_RUNNER], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
subjects = json.loads(proc.stdout.strip().splitlines()[-1])
# The out-of-range row is dropped from projection; the in-range one survives.
Expand Down Expand Up @@ -470,9 +461,7 @@ def test_number_threshold_scaled(tmp_path: Path):
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(tmp_path)
env["KB_TOOLS"] = str(Path(common.__file__).resolve().parent)
proc = subprocess.run(
[sys.executable, "-c", _NUMBER_RUNNER], env=env, capture_output=True, text=True
)
proc = _run_child([sys.executable, "-c", _NUMBER_RUNNER], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
subjects = json.loads(proc.stdout.strip().splitlines()[-1])
# 2500 >= 2000; 1999 < 2000 — the 1.999 boundary proves exact scaled ordering.
Expand Down Expand Up @@ -502,9 +491,7 @@ def test_number_out_of_int64_range_is_skipped(tmp_path: Path):
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(tmp_path)
env["KB_TOOLS"] = str(Path(common.__file__).resolve().parent)
proc = subprocess.run(
[sys.executable, "-c", _NUMBER_RUNNER], env=env, capture_output=True, text=True
)
proc = _run_child([sys.executable, "-c", _NUMBER_RUNNER], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
subjects = json.loads(proc.stdout.strip().splitlines()[-1])
# The out-of-range row is dropped from projection; the in-range one survives.
Expand Down Expand Up @@ -550,9 +537,7 @@ def test_unscaled_number_threshold_extra_dl_fails_loud(tmp_path: Path):
env = dict(os.environ)
env["FACTLOG_ROOT"] = str(tmp_path)
env["KB_TOOLS"] = str(Path(common.__file__).resolve().parent)
proc = subprocess.run(
[sys.executable, "-c", _NUMBER_RAISE_RUNNER], env=env, capture_output=True, text=True
)
proc = _run_child([sys.executable, "-c", _NUMBER_RAISE_RUNNER], env=env)
assert proc.returncode == 0, f"stdout={proc.stdout!r} stderr={proc.stderr!r}"
assert "FACTLOGERROR:" in proc.stdout
assert "version_num" in proc.stdout
Expand Down