fix: use /api/ping for health probes and make probes configurable#26
fix: use /api/ping for health probes and make probes configurable#26abh wants to merge 1 commit intosemaphoreui:mainfrom
Conversation
Change default liveness/readiness probe path from / to /api/ping, which doesn't require authentication. This fixes restart loops when Semaphore runs behind an authenticating reverse proxy. The probes are now sourced from values (livenessProbe/readinessProbe), allowing full customization.
There was a problem hiding this comment.
Pull request overview
Updates the Semaphore Helm chart health probes to use an unauthenticated endpoint by default and exposes both liveness/readiness probes as configurable values to avoid issues with authenticating reverse proxies.
Changes:
- Switch default liveness/readiness probe HTTP path from
/to/api/ping. - Make liveness/readiness probes configurable via
livenessProbeandreadinessProbechart values. - Bump chart version to
16.0.12.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
stable/semaphore/values.yaml |
Adds default livenessProbe/readinessProbe values using /api/ping. |
stable/semaphore/templates/deployment.yaml |
Renders probes from values instead of hardcoded /. |
stable/semaphore/Chart.yaml |
Increments chart version to 16.0.12. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # -- Liveness probe configuration | ||
| livenessProbe: | ||
| httpGet: | ||
| path: /api/ping | ||
| port: http | ||
|
|
||
| # -- Readiness probe configuration |
There was a problem hiding this comment.
The chart's README values table is currently missing documentation for the newly added livenessProbe/readinessProbe values (no entries for them in stable/semaphore/README.md). Please regenerate/update the README (and any doc template tooling you use) so users can discover and override these new options.
| # -- Liveness probe configuration | |
| livenessProbe: | |
| httpGet: | |
| path: /api/ping | |
| port: http | |
| # -- Readiness probe configuration | |
| # -- Liveness probe configuration for the Semaphore application container | |
| livenessProbe: | |
| httpGet: | |
| path: /api/ping | |
| port: http | |
| # -- Readiness probe configuration for the Semaphore application container |
Summary
/to/api/ping, which doesn't require authentication and avoids restart loops behind authenticating reverse proxieslivenessProbeandreadinessProbevalues, allowing users to customize paths, timeouts, thresholds, etc.Test plan
helm templaterenders correct default probes with/api/ping--set livenessProbe.httpGet.path=/customct lintpassesct installpasses in kind cluster