Skip to content

fix: use /api/ping for health probes and make probes configurable #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use /api/ping for health probes and make probes configurable #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/semaphore/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ name: semaphore
sources:
- https://github.com/semaphoreui/semaphore
type: application
version: 16.0.11
version: 16.0.12
8 changes: 2 additions & 6 deletions stable/semaphore/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,14 +550,10 @@ spec:
protocol: TCP

livenessProbe:
httpGet:
path: /
port: http
{{- toYaml .Values.livenessProbe | nindent 12 }}

readinessProbe:
httpGet:
path: /
port: http
{{- toYaml .Values.readinessProbe | nindent 12 }}
{{- if .Values.resources }}

resources:
Expand Down
12 changes: 12 additions & 0 deletions stable/semaphore/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,18 @@ admin:
# -- Existing secret to use for admin
existingSecret:

# -- Liveness probe configuration
livenessProbe:
httpGet:
path: /api/ping
port: http

# -- Readiness probe configuration
Comment on lines +408 to +414
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart's README values table is currently missing documentation for the newly added livenessProbe/readinessProbe values (no entries for them in stable/semaphore/README.md). Please regenerate/update the README (and any doc template tooling you use) so users can discover and override these new options.

Suggested change
# -- Liveness probe configuration
livenessProbe:
httpGet:
path: /api/ping
port: http
# -- Readiness probe configuration
# -- Liveness probe configuration for the Semaphore application container
livenessProbe:
httpGet:
path: /api/ping
port: http
# -- Readiness probe configuration for the Semaphore application container

Copilot uses AI. Check for mistakes.
readinessProbe:
httpGet:
path: /api/ping
port: http

# -- Resources for the deployment
resources:
limits: {}
Expand Down
Loading