Conversation
serpro69
force-pushed
the
kmp
branch
2 times, most recently
from
4b0f38f to
6ecfdc3
Compare
serpro69
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
serpro69
force-pushed
the
kmp
branch
9 times, most recently
from
d5568bd to
56cd35a
Compare
serpro69
added
breaking 💔
Prepare for refactoring to use kotlin multiplatform plugin. Shadow isn't really supported by kmp, and I really don't want to add any workarounds to make it work for jvm sources, so just killing it off.
Remove all integration test logic from build.gradl.kts files to further simplify build configs for kmp refactoring
Makes it easier to publish with consistent artifact names but w/o the need to modify the entire directory structure of the project
Use versioning plugin to determine if current build is a release or not, instead of relying on the outcome of 'tag' tasks. This makes things more reliable.
Leftovers from #252
Owner
Author
tasks.withType<AbstractPublishToMaven>().configureEach { ... }
runs the lambda when each matching task is created.
The nmcp plugin creates publishKotlinFakerBomPublicationToNmcpRepository
but doesn't bind the publication property immediately — it's set later.
Eagerly calling publication.name during configuration hit the null.
Moving it into onlyIf defers it to execution time, when the publication is guaranteed to be set.
- Replaced publishToSonatype → publishToAppropriateCentralRepository - Removed closeSonatypeStagingRepository (nmcp handles the staging/close flow internally) - Fixed release-minor which had tag before nativeCompile (inconsistent ordering vs other targets) - Updated comment "publish to sonatype and close staging repo" → "publish to maven central"
- Fix run_gradle.yml ref variable (github.event.inputs.ref → inputs.ref) - Fix pr.yml docs detection logic (mkdocs.yml/main.py were unreachable) - Remove undefined inputs.ref from pr.yml/master.yml callers - Fix firstOrNull in faker-provider-conventions (first makes ?: throw dead) - Fix kotest-bom copy-paste in bom comment - Update CLAUDE.md: Java 8→11, Kotlin 1.9→2.x, stale src paths - Remove duplicate configureondemand, unused Android properties - Remove dead nexus-publish plugin and gradle-plugin-bcv library from catalog - Delete dead utils/Ci.kt - Remove commented-out code in cli-bot/build.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO