Bugfix: Critical sysuser home directory creation failure with BTRFS_SUBVOLUME_HOME=yes on non-Btrfs paths#1609
Closed
silverhadch wants to merge 0 commit intoshadow-maint:masterfrom
Closed
Bugfix: Critical sysuser home directory creation failure with BTRFS_SUBVOLUME_HOME=yes on non-Btrfs paths#1609silverhadch wants to merge 0 commit intoshadow-maint:masterfrom
silverhadch wants to merge 0 commit intoshadow-maint:masterfrom
Conversation
Contributor
Author
|
CC: @Conan-Kudo |
Contributor
|
The commit message needs to be reformatted so that it's 70 chars for the title and the rest of the information needs to be in the commit body (wrapped at 79 chars). |
silverhadch
force-pushed
the
master
branch
2 times, most recently
from
29f0d3f to
f7ccf92
Compare
silverhadch
changed the title
Conan-Kudo
approved these changes
Apr 14, 2026
silverhadch
changed the title
ikerexxe
reviewed
Apr 15, 2026
silverhadch
force-pushed
the
master
branch
3 times, most recently
from
e5d68a8 to
aaa34da
Compare
silverhadch
force-pushed
the
master
branch
2 times, most recently
from
94f9613 to
67660a2
Compare
silverhadch
force-pushed
the
master
branch
2 times, most recently
from
fc48246 to
8a0c79b
Compare
alejandro-colomar
force-pushed
the
master
branch
from
1b88b09 to
f6b2a43
Compare
Collaborator
|
I've pushed a few changes to your branch, which resolve some issues. I've also significantly changed the design of the function. Now it's much simpler. |
Collaborator
|
Oops, I pushed by accident the contents of the master branch, and that has closed the PR. Would you mind reopening? You should get the commits from #1613. |
Collaborator
|
Oh, I can re-open myself. (No, it doesn't re-open; github is buggy.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a critical bug. Previously, Btrfs subvolume creation was only applied on-demand, but now it's forced for all users whenever BTRFS_SUBVOLUME_HOME=yes is set. That logic is too aggressive: it causes system users with home directories in places like /var or /run to fail because those paths aren't Btrfs-backed. KDE Linux fails to boot with Btrfs home enabled because sysuser configurations require a home directory on tmpfs, yet the option forces a Btrfs subvolume even for those state directories. Without this patch, sysusers aren't created properly, as seen in this failing pipeline: https://invent.kde.org/kde-linux/kde-linux/-/pipelines/1215866. With the patch, the system falls back to a regular directory when a Btrfs home is requested by config or flag but the target path isn't Btrfs-backed, and it throws a warning to stderr. That allows sysusers on tmpfs or other non-Btrfs state directories to be created successfully, and the pipeline passes: https://invent.kde.org/kde-linux/kde-linux/-/pipelines/1216261. This resolves the boot failure, fixes Plasma login and setup, and generally prevents breakage for any sysuser with a home on a non-Btrfs filesystem with said option set.