Add web remote buttons for audio and subtitle cycling - #641
Open
mechaigor-hash wants to merge 1 commit into
Open
Add web remote buttons for audio and subtitle cycling#641mechaigor-hash wants to merge 1 commit into
mechaigor-hash wants to merge 1 commit into
Conversation
Owner
|
Starting review today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SUBSandAUDIObuttons to the built-in FS42 web remote.The buttons use the existing mpv control endpoints to cycle subtitle and audio tracks on the currently playing item:
POST /player/mpv/cycle-subtitlesPOST /player/mpv/cycle-audioI’ve kept this deliberately small after the previous PR feedback. This only updates
fs42/fs42_server/static/remote.html; it does not change playback defaults, language preference logic,play_file(), sequence scanning, or the separate legacy remote app.Testing
Ran:
Also checked the remote HTML for the new buttons and endpoint calls.