NEW Migrate TinyMCE code and config to new repo#1

Merged

emteknetnz merged 1 commit intosilverstripe:1.0from

creative-commoners:pulls/1.0/migrate-here

Mar 13, 2025

Member

GuySartorelli commented Feb 12, 2025

Issue

Move TinyMCE code into its own module #2

GuySartorelli marked this pull request as draft

February 12, 2025 21:31

GuySartorelli mentioned this pull request

Move TinyMCE code into its own module #2

Closed

10 tasks

GuySartorelli force-pushed the pulls/1.0/migrate-here branch 8 times, most recently from ad8627d to 2246e98 Compare

February 25, 2025 00:29

GuySartorelli force-pushed the pulls/1.0/migrate-here branch 9 times, most recently from 004527d to 83b9f11 Compare

March 4, 2025 05:40

GuySartorelli force-pushed the pulls/1.0/migrate-here branch 10 times, most recently from d62075b to 1e05bbf Compare

March 10, 2025 05:14

GuySartorelli commented

View reviewed changes

_config.php Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

_config/injector.yml Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

_config/injector.yml Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

client/lang/src/en.json Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

client/src/components/TinyMceHtmlEditorField/TinyMceHtmlEditorField.js Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

client/src/entwine/TinyMceHtmlEditorField.js Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

client/src/tinymce/README.txt Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

client/tinymce_lang/README.md Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

docs/en/01_Configuration.md Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

docs/en/02_Typography.md Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

docs/en/03_Frontend.md Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

phpcs.xml.dist Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

src/TinyMCEConfig.php Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

tests/behat/features/apply-formatting.feature Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

tests/php/TinyMCECombinedGeneratorTest.php Show resolved Hide resolved

GuySartorelli commented

View reviewed changes

webpack.config.js Show resolved Hide resolved

emteknetnz requested changes

View reviewed changes

Member

emteknetnz left a comment

This was an initial peer review which I wanted to submit now so I didn't loose any feedback. I may submit some more feedback on this PR in the near future.

docs/en/01_Configuration.md Show resolved Hide resolved

docs/en/01_Configuration.md Show resolved Hide resolved

docs/en/01_Configuration.md Show resolved Hide resolved

docs/en/01_Configuration.md Show resolved Hide resolved

docs/en/01_Configuration.md Show resolved Hide resolved

tests/behat/features/apply-formatting.feature Outdated Show resolved Hide resolved

webpack.config.js Outdated Show resolved Hide resolved

webpack.config.js Outdated Show resolved Hide resolved

src/TinyMCECombinedGenerator.php Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

This was referenced Mar 11, 2025

API Deprecate API that will be removed in CMS 6 silverstripe/silverstripe-framework#11630

Merged

DOC Document API deprecations for TinyMCE migration silverstripe/developer-docs#713

Merged

emteknetnz requested changes

View reviewed changes

_config/config.yml Show resolved Hide resolved

src/TinyMCECombinedGenerator.php Show resolved Hide resolved

GuySartorelli force-pushed the pulls/1.0/migrate-here branch 2 times, most recently from aff183e to 191068a Compare

March 11, 2025 22:47


          MNT Add composer.json file

8684a8e

GuySartorelli force-pushed the pulls/1.0/migrate-here branch from 191068a to 8684a8e Compare

March 12, 2025 02:13

GuySartorelli marked this pull request as ready for review

March 13, 2025 00:37

emteknetnz approved these changes

View reviewed changes

emteknetnz merged commit 43cc1b6 into silverstripe:1.0

Member Author

GuySartorelli commented Mar 13, 2025

I accidentally gave this a bad commit message, which got used in the merge.
We agreed offline that since this isn't in use yet (not even in packagist yet) it's safe to force-push to update the commit message, which I've now done.

GuySartorelli deleted the pulls/1.0/migrate-here branch

March 13, 2025 23:16

Member

emteknetnz commented Mar 13, 2025 •

edited

Loading

Yup - the old commit message was MNT Add composer.json file which wouldn't have shown in the automatically generated changelog - we agreed offline that Guy should force put an updated commit message

The updated commit message is NEW Migrate TinyMCE code and config to new repo

GuySartorelli mentioned this pull request

Fix various issues #6

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet