Chore(star-review): Add codehash comment clarification#67
Open
riccardopersiani wants to merge 1 commit intomasterfrom
Open
Chore(star-review): Add codehash comment clarification#67riccardopersiani wants to merge 1 commit intomasterfrom
riccardopersiani wants to merge 1 commit intomasterfrom
Conversation
amusingaxl
reviewed
Apr 17, 2026
| - [ ] A new comment in the PR contains link to the deployed spell(s) and Tenderly vnet(s). | ||
| - [ ] The comment also contains codehash of the deployed mainnet spell. | ||
| - [ ] The codehash matches one produced locally from the reviewed source code. | ||
| - [ ] IF metadata is present in the bytecode, remove the Solidity CBOR metadata footer from both the deployed bytecode and the local bytecode before computing the hash. The footer length must be read from the last 2 bytes of the bytecode. |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to just temporarily tweak the Foundry config instead of doing this manually?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.