Skip to content

Chore(star-review): Add codehash comment clarification #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riccardopersiani wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

Chore(star-review): Add codehash comment clarification #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spell/star-spell-reviewer-checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ EXECUTED_TESTS_LOGS
- [ ] A new comment in the PR contains link to the deployed spell(s) and Tenderly vnet(s).
- [ ] The comment also contains codehash of the deployed mainnet spell.
- [ ] The codehash matches one produced locally from the reviewed source code.
- [ ] IF metadata is present in the bytecode, remove the Solidity CBOR metadata footer from both the deployed bytecode and the local bytecode before computing the hash. The footer length must be read from the last 2 bytes of the bytecode.
Copy link
Copy Markdown
Contributor

@amusingaxl amusingaxl Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to just temporarily tweak the Foundry config instead of doing this manually?

- [ ] Every spell is verified on Etherscan or other primary block explorer for this chain.
- [ ] Every spell code matches local source code at the "good to deploy" commit.
- [ ] Etherscan settings (optimizer, EVM version, license) match local ones.
Expand Down
Loading