NO-SNOW: Fix flaky DatabaseMetaData tests#2546
Merged
sfc-gh-dheyman merged 1 commit intoMar 11, 2026
Merged
Conversation
f95acd1 to
e15e0d4
Compare
afecd53 to
96c898a
Compare
ddde298 to
89963bc
Compare
d4cd8f2 to
6606c2a
Compare
6606c2a to
dcb6ac1
Compare
dcb6ac1 to
8ba2f4c
Compare
sfc-gh-rkowalski
approved these changes
Mar 11, 2026
sfc-gh-pfus
approved these changes
Mar 11, 2026
Collaborator
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
This change fixes stream metadata retrieval by replacing column index access with column name access in the
SnowflakeDatabaseMetaDataImplclass. The fix addresses three key issues:namevariable instead of the undefinedstreamNamevariableAdditionally, the change removes the conditional logic that only added schema filtering when stream name was null or contained wildcards, ensuring schema filtering is always applied. Test cases have been updated to disable wildcard support in show metadata commands to ensure consistent behavior.