NO-SNOW: Fix flaky testMultipleChunks test#2547
Merged
sfc-gh-dheyman merged 2 commits intoMar 10, 2026
Merged
Conversation
sfc-gh-dheyman
force-pushed
the
03-10-no-snow_fix_flaky_testgetstreams_test
branch
from
d7b4235 to
f95acd1
Compare
sfc-gh-dheyman
force-pushed
the
03-10-no-snow_fix_flaky_testmultiplechunks_test
branch
from
46cd916 to
c06cf75
Compare
sfc-gh-dheyman
changed the base branch from
03-10-no-snow_fix_flaky_testgetstreams_test
to
graphite-base/2547
sfc-gh-dheyman
force-pushed
the
graphite-base/2547
branch
from
f95acd1 to
c6ce571
Compare
sfc-gh-dheyman
force-pushed
the
03-10-no-snow_fix_flaky_testmultiplechunks_test
branch
from
c06cf75 to
b7ac530
Compare
sfc-gh-merbel
approved these changes
Mar 10, 2026
sfc-gh-pfus
approved these changes
Mar 10, 2026
Collaborator
Author
Merge activity
|
sfc-gh-dheyman
deleted the
03-10-no-snow_fix_flaky_testmultiplechunks_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed telemetry test assertion for
TIME_CONSUME_FIRST_RESULTfield inResultSetLatestIT.testMultipleChunks(). The test was failing becauseTIME_CONSUME_FIRST_RESULTis only logged when the server providessendResultTime, which is not guaranteed. Removed this field from the required assertions and added a comment explaining that it's optional. The test now only asserts the presence of telemetry fields that are always expected when results span multiple chunks:TIME_CONSUME_LAST_RESULT,TIME_WAITING_FOR_CHUNKS,TIME_DOWNLOADING_CHUNKS, andTIME_PARSING_CHUNKS.