i18n: Lingo (ui)#1583
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis automated PR from Lingo.dev adds the new
Confidence Score: 4/5Safe to merge with minor fixes — two locale-specific string defects should be corrected before or shortly after landing. The Vietnamese lastDays string will render "Last # ngày" to all Vietnamese users because the word "Last" was never translated. The Indonesian ICU placeholder has an extra leading space ({ days, plural) that could cause runtime parse errors in strict ICU environments. Both issues are confined to a single string in a single locale each and do not affect any other part of the codebase. packages/i18n/messages/web/vi/common.json (untranslated "Last" prefix) and packages/i18n/messages/web/id/common.json (malformed ICU placeholder) need correction before these translations go live. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
EN[English source\ncommon.json] -->|Lingo.dev translates| LOCK[i18n.lock\nchecksums updated]
EN --> AR & DE & EL & ES & FI & FR
EN --> ID & IT & JA & KO & NL & PL
EN --> PT & RU & TR & UK & VI & ZH
ID:::warn -->|"{ days, plural …"\nleading space| BUG1[⚠ Possible ICU parse error]
VI:::warn -->|"Last {days…}"\nuntranslated prefix| BUG2[⚠ Mixed-language UI output]
classDef warn fill:#fff3cd,stroke:#f0ad4e
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
EN[English source\ncommon.json] -->|Lingo.dev translates| LOCK[i18n.lock\nchecksums updated]
EN --> AR & DE & EL & ES & FI & FR
EN --> ID & IT & JA & KO & NL & PL
EN --> PT & RU & TR & UK & VI & ZH
ID:::warn -->|"{ days, plural …"\nleading space| BUG1[⚠ Possible ICU parse error]
VI:::warn -->|"Last {days…}"\nuntranslated prefix| BUG2[⚠ Mixed-language UI output]
classDef warn fill:#fff3cd,stroke:#f0ad4e
|
4a2d30f to
11973a2
Compare
11973a2 to
8fa18e2
Compare
8211576 to
fc27d66
Compare
9434107 to
62f09b2
Compare
62f09b2 to
24e2107
Compare
| "allProviders": "Semua penyedia", | ||
| "noProviders": "Tidak ada penyedia yang dipilih", | ||
| "providerListSeparator": " / ", | ||
| "lastDays": "{ days, plural, one {# hari} other {# hari}} terakhir", |
There was a problem hiding this comment.
The ICU placeholder has a leading space before the argument name:
{ days, plural, ...}. While lenient parsers may trim it, this is inconsistent with every other locale and could trip strict ICU parsers that expect the identifier to start immediately after {.
| "lastDays": "{ days, plural, one {# hari} other {# hari}} terakhir", | |
| "lastDays": "{days, plural, one {# hari} other {# hari}} terakhir", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Too many files changed for review. ( |
Includes UI and docs translations plus the signing workflow fix.
Hey team,
Lingo.dev here with fresh translations!
In this update
Next Steps