Skip to content

Fixing HashTest Bugs #20840 and #21071#20881

Merged
wangxin merged 4 commits into
sonic-net:masterfrom
gshemesh2:guys_bracnh
Jan 8, 2026
Merged

Fixing HashTest Bugs #20840 and #21071#20881
wangxin merged 4 commits into
sonic-net:masterfrom
gshemesh2:guys_bracnh

Conversation

@gshemesh2

@gshemesh2 gshemesh2 commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Description of PR

Summary:
Fixing Bugs #20840 (comment) and #21071 (HashTest)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Fixing Bug #20840 (comment) and #21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Supported testbed topology if it's a new test case?
N/A

Documentation

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@gshemesh2 gshemesh2 changed the title Fixing Bug https://github.com/sonic-net/sonic-mgmt/issues/20840#issuecomment-3353468394 (HashTest) Fixing Bug https://github.com/sonic-net/sonic-mgmt/issues/20840#issuecomment-3353468394 , (HashTest) Nov 24, 2025
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@gshemesh2 gshemesh2 changed the title Fixing Bug https://github.com/sonic-net/sonic-mgmt/issues/20840#issuecomment-3353468394 , (HashTest) Fixing Bugs https://github.com/sonic-net/sonic-mgmt/issues/20840#issuecomment-3353468394 , https://github.com/sonic-net/sonic-mgmt/issues/21071(HashTest) Nov 24, 2025
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wangxin

wangxin commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator

@gshemesh2 Can you improve the PR title? https://www.graphite.com/guides/best-pr-title-guidelines

@gshemesh2 gshemesh2 changed the title Fixing Bugs https://github.com/sonic-net/sonic-mgmt/issues/20840#issuecomment-3353468394 , https://github.com/sonic-net/sonic-mgmt/issues/21071(HashTest) Fixing HashTest Bugs 20840# and #21071 Dec 25, 2025
@gshemesh2 gshemesh2 changed the title Fixing HashTest Bugs 20840# and #21071 Fixing HashTest Bugs #20840 and #21071 Dec 25, 2025
@wangxin wangxin merged commit 7bb8f71 into sonic-net:master Jan 8, 2026
19 checks passed
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No
thisptr-sh pushed a commit to thisptr-sh/sonic-mgmt that referenced this pull request Jan 21, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Apr 1, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
Anirudh-nokia pushed a commit to Anirudh-nokia/sonic-mgmt-fork that referenced this pull request Apr 7, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: ayya <anirudh.ayya@nokia.com>
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Apr 20, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
@mlok-nokia mlok-nokia added the Request for 202511 branch Request to backport a change to 202511 branch label May 19, 2026
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Jun 11, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Jun 11, 2026
…0881)

What is the motivation for this PR?
Fixing Bug sonic-net#20840 (comment) and sonic-net#21071

by override send_and_verify_packets on class IPinIPHashTest to make sure that the verification of the packet arrival will succeed

How did you do it?
fixed HashTest.check_within_expected_range usage
Fixed IPinIP Hash Test by override send_and_verify_packets on class IPinIPHashTest and use no timeout for the packets arrival verification.

How did you verify/test it?
Ran fib_test::test_hash locally.
Conducted a full overnight regression test.

Any platform specific information?
No

Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #25323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants