Add ignore_expected_loganalyzer_exceptions fixture to test_lldp_entry_table_after_lldp_restart#25259
Merged
Conversation
…dp_entry_table_after_lldp_restart Signed-off-by: sakshamkhurana <sakkhurana@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes intermittent teardown failures in
lldp.test_lldp_syncd::test_lldp_entry_table_after_lldp_restartcaused by transientmonit 'routeCheck' status failedERR lines in syslog after the LLDP container is restarted.This is a one-line fix: the test was missing the
ignore_expected_loganalyzer_exceptionsfixture in its signature, so the existing ignore-regex (added in PR #15258) was never installed for this test. Its sibling tests (test_lldp_entry_table_after_cont_flap,test_lldp_entry_table_after_all_batched_flap) already declare the same fixture and pass cleanly.Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_lldp_entry_table_after_lldp_restarthas been flaking at ~12% onvlab-03for weeks. The test body itself passes — the failure happens at teardown when loganalyzer flags anERRmonit[...]: 'routeCheck' status failedline that is emitted momentarily while LLDP is being restarted (systemctl restart lldp). Routes briefly fail their consistency check while LLDPrepopulates neighbor info, then recover on the next monit poll.How did you do it?
How did you verify/test it?
Any platform specific information?
N/a
Supported testbed topology if it's a new test case?
N/a
Documentation
N/a