Convert TRAYs to use ItemToggle#43689
Open
Dirius77 wants to merge 1 commit intospace-wizards:masterfrom
Open
Conversation
PJBot
added
S: Untriaged
Pok27
added
P3: Standard
Contributor
|
Merge after #43161 |
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Switched TRAYs from manually handling activations and visuals to instead use ItemToggleComponent and Systems
Why / Balance
This makes the code a decent bit cleaner, it also makes it easier to add tray functionality to other items in the future as it won't also inherently bring the ability to be turned on and off with it as a byproduct.
Technical details
Removed a lot of redundant code and added ItemToggle to the trayScanner. Also switched the scanner to using AutoGenerateComponentState instead of its own state handling since the only thing left was the radius float.
Media
This does not change anything in a way that can be seen visually.
Requirements
Breaking changes
Changelog