Add native SwiftUI.Bindable support for iOS 17+ - #389
Merged
Conversation
Clients with a minimum deployment target of iOS 17 can now use SwiftUI's native @bindable property wrapper with Store, including the .sending(action:) API for custom action routing. - Add _NativeStoreBindable, mirroring _StoreBindable for native @bindable instead of @Perception.Bindable - Suppress false-positive Perception runtime warnings on iOS 17+ by setting skipPerceptionChecking in Store's state-reading paths - Add NativeBindableStoreTests covering all three sending overloads - Add NativeMultiCounterView sample demonstrating @bindable usage without WithPerceptionTracking Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
johnnewman-square
force-pushed
the
jn/native-bindable-ios17
branch
from
April 9, 2026 15:12
07d1637 to
9b46641
Compare
Replace @available annotations with guard #available + XCTSkip to prevent XCTest from failing on iOS 16 when it discovers but cannot execute availability-gated test methods. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
johnnewman-square
marked this pull request as ready for review
April 9, 2026 18:20
Contributor
Author
|
@codex review |
robmaceachern
approved these changes
Apr 10, 2026
Add iOS 17+ @bindable examples to the adoption guide and a native child-store observation test to cover the skipPerceptionChecking suppression in Store.access(). Fix trailing whitespace in test markers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@robmaceachern I have addressed the feedback, thanks again. One thing I wanted to be sure to mention is that the |
2 tasks
johnnewman-square
added a commit
that referenced
this pull request
Apr 21, 2026
This PR builds on the changes from #389. ## Summary - gate `skipPerceptionChecking` behind `#if DEBUG` via a shared helper - apply the debug-only suppression to both `readState` and child-wrapper `access(...)` - add `test_nativeOptionalChildStoreObservation` so native observation covers the wrapper path through `Store.access(...)` - include the updated `Samples/Tuist/Package.resolved` ## Why Perception only consults `skipPerceptionChecking` from its debug-only checking path, so release builds do not need the TaskLocal wrapper. The new native optional-wrapper test closes the coverage gap in the path that motivated the original suppression. ## Test plan - [x] Ensure the new test passes - [x] Look for regressions on the `ObservableComposition` app. Co-authored-by: Codex <codex@openai.com>
7 tasks
johnnewman-square
added a commit
that referenced
this pull request
Jul 16, 2026
PRs #389 and #390 automatically suppressed Perception runtime warnings on platforms using native Observation. This restores the warnings by default while preserving an opt-in suppression path. ## Summary - Add `Runtime.Configuration.suppressPerceptionCheckingWhenUsingObservation`, defaulting to `false` - Continue normal Store access unless suppression is explicitly enabled - Apply suppression only in debug builds on iOS 17+, macOS 14+, tvOS 17+, and watchOS 10+ - Cover both direct state reads and child Store wrapper access - Add tests for the default warning behavior and opt-in suppression ## Test plan - [x] Run `StoreTests` on iOS 17.5 — 25 passed - [x] Run `StoreTests` on iOS 16.2 — passed with 8 expected skips - [x] Run the ObservableComposition sample app on iOS 17 to ensure the warnings are occurring by default. ## Checklist - [x] Unit Tests - [x] UI Tests (not applicable) - [x] Snapshot Tests (not applicable) - [x] I have made corresponding changes to the documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for the
.sending(...)API on iOS 17+ Bindables. The original implementation worked withPerception.Bindable, which is marked as obsolete on 17+, requiring clients to switch toSwiftUI.Bindablewhere these APIs didn't previously exist.Summary
_NativeStoreBindable, a native@Bindableequivalent of_StoreBindablefor iOS 17+ clients, supporting all three.sending()overloads (sink:action:,closure:, andaction:forSingleActionModel)skipPerceptionCheckinginStore's state-reading and child-store scoping paths, where thePerceptibleoverload ofPerceptionRegistrar.accessis selected at compile time even though native observation is trackingStoreTestsmirroring the existingPerception.Bindabletests, usingXCTSkipto skip on iOS 16NativeMultiCounterViewsample demonstrating@Bindableusage withoutWithPerceptionTracking, wired via#availableinMultiCounterScreenTest plan
WorkflowSwiftUI-Testson an iOS 17+ simulator — verify the 4 native binding tests passWorkflowSwiftUI-Testson an iOS 16 simulator — verify the native binding tests are skipped viaXCTSkipand existing tests still passObservableCompositionsample on iOS 17+ — verifyNativeMultiCounterViewis used with no Perception runtime warningsObservableCompositionsample on iOS 16 — verifyMultiCounterViewis used as fallback🤖 Generated with Claude Code