Skip to content

services/stellar-archivist: fix nil pointer panics in S3Storage.ListFiles #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamirms merged 1 commit into from
Apr 22, 2026
+4 −3
Merged

services/stellar-archivist: fix nil pointer panics in S3Storage.ListFiles #5934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions support/storage/s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,11 @@ func (b *S3Storage) ListFiles(pth string) (chan string, chan error) {
for {
for _, c := range resp.Contents {
params.Marker = c.Key
log.WithField("key", *c.Key).Trace("s3: ListFiles")
ch <- *c.Key
key := aws.StringValue(c.Key)
log.WithField("key", key).Trace("s3: ListFiles")
ch <- key
Comment thread
satyamz marked this conversation as resolved.
}
if *resp.IsTruncated {
if aws.BoolValue(resp.IsTruncated) {
Comment thread
satyamz marked this conversation as resolved.
req, resp = b.svc.ListObjectsRequest(params)
if b.unsignedRequests {
req.Handlers.Sign.Clear() // makes this request unsigned
Expand Down
Loading