Scikit for CmakeUpdates#229
Conversation
volkm
left a comment
volkm
left a comment
There was a problem hiding this comment.
Overall LGTM. I have some smaller clarifying questions.
Note that I opted to use pybind version 2.12.1 for now. Pybind versions 2.13 lead to a build error for me which I still need to investigate.
| ## Quick-n-dirty approach (much faster than doing the install, which copies thousands of files) | ||
| #ln -s /tmp/boost_${boost_version_under}/boost /usr/include/boost | ||
|
|
||
| # Install ginac |
There was a problem hiding this comment.
Why can we not use the ginac package from the package manager?
There was a problem hiding this comment.
We probably can, but the general advice seems to be to not use brew (and similar things hold for other package managers).
https://cibuildwheel.pypa.io/en/stable/faq/#missing-dependencies
I think having the ability to build a version from source is probably good in terms of flexibility here.
There was a problem hiding this comment.
Ok, so we should try to not rely on homebrew. In this case, I suggest that we also try to build cln manually, and maybe some other libraries if needed.
3 participants
Updates that build upon the cmake updates in storm. This now allows building wheels.
Fixes #216.
Fixes #161