Skip to content

fix(bug): temporarily fix toolbar regression#7782

Merged
pikurasa merged 1 commit into
sugarlabs:masterfrom
pikurasa:toolbar-regression
Jul 11, 2026
Merged

fix(bug): temporarily fix toolbar regression#7782
pikurasa merged 1 commit into
sugarlabs:masterfrom
pikurasa:toolbar-regression

Conversation

@pikurasa

@pikurasa pikurasa commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Temporary fix for #7777 (comment)

PR Category

  • Bug fix

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.00%. Comparing base (7ee23aa) to head (4408ee5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7782      +/-   ##
==========================================
- Coverage   59.00%   59.00%   -0.01%     
==========================================
  Files         175      175              
  Lines       57920    57916       -4     
==========================================
- Hits        34176    34172       -4     
  Misses      23744    23744              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pikurasa

pikurasa commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

It passed the smoke test. Here are my results from a private tab and via a local server:

Screenshot From 2026-07-10 22-39-33 Screenshot From 2026-07-10 22-38-58 Screenshot From 2026-07-10 22-38-51

@ssz2605

ssz2605 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

@pikurasa are you pointing out to PR category check that's failing? , that was the only check failing I fixed that though

@github-actions github-actions Bot added bug fix Fixes a bug or incorrect behavior size/XS Extra small: < 10 lines changed area/javascript Changes to JS source files labels Jul 11, 2026
@pikurasa

Copy link
Copy Markdown
Collaborator Author

@pikurasa are you pointing out to PR category check that's failing? , that was the only check failing I fixed that though

Yes, that was the only thing failing, I think.

Have you tested it?

@ssz2605

ssz2605 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

@pikurasa Not yet , I will test it.. just was confused what exactly the issue you were facing , will now review it

@ssz2605

ssz2605 commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

@pikurasa Tested locally Looks good as a temporary workaround to unblock master

@pikurasa pikurasa merged commit 3aa560a into sugarlabs:master Jul 11, 2026
12 of 13 checks passed
@pikurasa

Copy link
Copy Markdown
Collaborator Author

@pikurasa Tested locally Looks good as a temporary workaround to unblock master

Thanks. I'm merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/javascript Changes to JS source files bug fix Fixes a bug or incorrect behavior size/XS Extra small: < 10 lines changed

Projects

Development

Successfully merging this pull request may close these issues.

2 participants