The pagefault and fork implementation under riscv arch - #196
Merged
Conversation
ken4647
reviewed
May 28, 2025
ZZJJWarth
force-pushed
the
riscv_pagefault_fork
branch
from
July 17, 2025 08:22
a37af8c to
779f7c6
Compare
ken4647
reviewed
Jul 20, 2025
Contributor
|
It seems like your commit message has a '-' at the beginning. Please consider removing it. |
ZZJJWarth
force-pushed
the
riscv_pagefault_fork
branch
2 times, most recently
from
July 20, 2025 16:01
7cf4d8c to
c24b72e
Compare
ken4647
reviewed
Jul 21, 2025
ken4647
left a comment
Contributor
There was a problem hiding this comment.
warning: comparing with null is better expressed by the `.is_null()` method
--> api/ruxos_posix_api/src/imp/execve/mod.rs:110:12
|
110 | if argv != null() {
| ^^^^^^^^^^^^^^ help: try: `argv.is_null()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
= note: `#[warn(clippy::cmp_null)]` on by default
some warnings should be fixed
Contributor
|
I think you should re-edit your commit message as "feat(arch): support mmap and process for riscv", and remove the "-" be front of the message. |
ZZJJWarth
force-pushed
the
riscv_pagefault_fork
branch
from
July 21, 2025 13:35
c24b72e to
0d21573
Compare
ken4647
approved these changes
Jul 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, the functions below would be added to ruxos: