Skip to content

The pagefault and fork implementation under riscv arch - #196

Merged
ken4647 merged 1 commit into
syswonder:devfrom
ZZJJWarth:riscv_pagefault_fork
Jul 21, 2025
Merged

The pagefault and fork implementation under riscv arch#196
ken4647 merged 1 commit into
syswonder:devfrom
ZZJJWarth:riscv_pagefault_fork

Conversation

@ZZJJWarth

Copy link
Copy Markdown
Contributor

In this pull request, the functions below would be added to ruxos:

  • Have pagefault available in riscv arch
  • Make a process by fork in riscv arch
  • Load a program via execv in riscv arch

Comment thread modules/ruxhal/src/arch/riscv/context.rs Outdated
Comment thread modules/ruxhal/src/arch/riscv/gp.rs Outdated
Comment thread scripts/prebuild/riscv64.mk Outdated
@ZZJJWarth
ZZJJWarth force-pushed the riscv_pagefault_fork branch from a37af8c to 779f7c6 Compare July 17, 2025 08:22
Comment thread api/ruxos_posix_api/src/imp/fd_ops.rs Outdated
Comment thread ulib/include/sys/types.h Outdated
Comment thread modules/ruxhal/src/arch/riscv/context.rs Outdated
@ken4647

ken4647 commented Jul 20, 2025

Copy link
Copy Markdown
Contributor

It seems like your commit message has a '-' at the beginning. Please consider removing it.

@ZZJJWarth
ZZJJWarth force-pushed the riscv_pagefault_fork branch 2 times, most recently from 7cf4d8c to c24b72e Compare July 20, 2025 16:01

@ken4647 ken4647 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: comparing with null is better expressed by the `.is_null()` method
   --> api/ruxos_posix_api/src/imp/execve/mod.rs:110:12
    |
110 |         if argv != null() {
    |            ^^^^^^^^^^^^^^ help: try: `argv.is_null()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null
    = note: `#[warn(clippy::cmp_null)]` on by default

some warnings should be fixed

@ken4647

ken4647 commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

I think you should re-edit your commit message as "feat(arch): support mmap and process for riscv", and remove the "-" be front of the message.

@ZZJJWarth
ZZJJWarth force-pushed the riscv_pagefault_fork branch from c24b72e to 0d21573 Compare July 21, 2025 13:35
@ken4647
ken4647 merged commit 4a9ee63 into syswonder:dev Jul 21, 2025
10 checks passed
@ken4647 ken4647 mentioned this pull request Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants