Add task composer task return value override#612
Open
marip8 wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 77.42% 77.41% -0.02%
==========================================
Files 246 246
Lines 13916 13923 +7
==========================================
+ Hits 10775 10779 +4
- Misses 3141 3144 +3
🚀 New features to boost your workflow:
|
Levi-Armstrong
requested changes
Apr 18, 2025
Levi-Armstrong
left a comment
Contributor
There was a problem hiding this comment.
The only request is to add unit tests to cover the new functionality.
marrts
reviewed
Jun 25, 2025
| { | ||
| results.return_value = return_value_override_; | ||
| results.status_message += " (Return value overridden to " + std::to_string(return_value_override_) + ")"; | ||
| results.color = "yellow"; |
Contributor
There was a problem hiding this comment.
Personally, I would vote for a color other than yellow as that is already used elsewhere. Maybe a blue or cyan? I was going to say gray, but that appears to already be used to represent "abort"
Contributor
|
@marip8 I assume we still want to get this merged in? |
Levi-Armstrong
force-pushed
the
feature/task-composer-return-value-override
branch
from
February 4, 2026 02:33
8c70c44 to
9fc3b5f
Compare
Levi-Armstrong
force-pushed
the
feature/task-composer-return-value-override
branch
from
February 4, 2026 15:29
9fc3b5f to
d3f7595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a means to override the return value of a task. This can be useful for debugging (e.g., forcing a task composer graph to take a specific path) and potentially for unit testing (for the same reason).