Skip to content

Add task composer task return value override#612

Open
marip8 wants to merge 2 commits into
tesseract-robotics:masterfrom
marip8:feature/task-composer-return-value-override
Open

Add task composer task return value override#612
marip8 wants to merge 2 commits into
tesseract-robotics:masterfrom
marip8:feature/task-composer-return-value-override

Conversation

@marip8

@marip8 marip8 commented Apr 16, 2025

Copy link
Copy Markdown
Contributor

This PR provides a means to override the return value of a task. This can be useful for debugging (e.g., forcing a task composer graph to take a specific path) and potentially for unit testing (for the same reason).

@marip8 marip8 changed the title Task composer task return value override Add task composer task return value override Apr 16, 2025
@codecov

codecov Bot commented Apr 16, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.41%. Comparing base (c3e794f) to head (d3f7595).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...ract_task_composer/core/src/task_composer_node.cpp 62.50% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   77.42%   77.41%   -0.02%     
==========================================
  Files         246      246              
  Lines       13916    13923       +7     
==========================================
+ Hits        10775    10779       +4     
- Misses       3141     3144       +3     
Files with missing lines Coverage Δ
.../tesseract_task_composer/core/task_composer_node.h 100.00% <ø> (ø)
...ract_task_composer/core/src/task_composer_node.cpp 81.26% <62.50%> (-0.48%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Levi-Armstrong Levi-Armstrong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only request is to add unit tests to cover the new functionality.

{
results.return_value = return_value_override_;
results.status_message += " (Return value overridden to " + std::to_string(return_value_override_) + ")";
results.color = "yellow";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would vote for a color other than yellow as that is already used elsewhere. Maybe a blue or cyan? I was going to say gray, but that appears to already be used to represent "abort"

@Levi-Armstrong

Copy link
Copy Markdown
Contributor

@marip8 I assume we still want to get this merged in?

@Levi-Armstrong
Levi-Armstrong force-pushed the feature/task-composer-return-value-override branch from 8c70c44 to 9fc3b5f Compare February 4, 2026 02:33
@Levi-Armstrong
Levi-Armstrong force-pushed the feature/task-composer-return-value-override branch from 9fc3b5f to d3f7595 Compare February 4, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants