Update debian package CI job#750
Open
marip8 wants to merge 2 commits into
Open
Conversation
…ring ref name instead of latest available repository tag
marip8
changed the title
marip8
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to generate debians of previous tagged versions of this repository to add to the releases, and I'm running into the issue where the debian package build CI job identifies the latest tagged version (e.g., 0.35.0) as the platform on which to build the debians despite the workflow being invoked for a previous tag (e.g., 0.29.2). See this workflow as an example.
This PR updates the debian package CI job to pull the major and minor versions from the triggering git ref name rather than from the latest tag of the repository. This changes allows the workflow to be run on command for non-latest tags (e.g., to generate debians for existing releases). If this workflow is triggered by a git ref that is not a tag compatible with semantic versioning, theget-tagstep will fail and report the error.This PR updates the debian package CI job to get the target major, minor and patch versions from workflow dispatch text inputs provided by the user triggering the build. It then uses the major and minor versions to pull the correct Docker image for the build and specifies the full tag (
major.minor.patch) as the repository ref to check out for the build