chore(ci): bump github/codeql-action from 4 to 4.37.3 - #241
Closed
dependabot[bot] wants to merge 1 commit into
Closed
chore(ci): bump github/codeql-action from 4 to 4.37.3#241dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4 to 4.37.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v4...v4.37.3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.37.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
|
|
Contributor
Author
|
Looks like github/codeql-action is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/github_actions/github/codeql-action-4.37.3
branch
August 4, 2026 18:57
thiagoluga
added a commit
that referenced
this pull request
Aug 5, 2026
…n lockstep (#266) * chore(deps): bump the safe dependency lot, with the Hangfire family in lockstep All eleven Dependabot PRs (#241-#251) were closed unmerged, so the bumps are redone here as one verified change. This is the lot where the new version is a patch or minor within the same major; the major jumps (Npgsql 9->10, Microsoft.Data.Sqlite 9->10, Microsoft.Data.SqlClient 5->7, TestHost 8->10, Aspire 9.5->13.4) are deliberately left out and assessed separately. Hangfire.Core, Hangfire.SqlServer and Hangfire.AspNetCore move together to 1.8.24. Hangfire.NetCore arrives transitively and pins Hangfire.Core to an exact version, so bumping any one member alone fails restore with NU1608 — which is why #246 and #247 were red and could never have gone green on their own. dependabot.yml now groups Hangfire* so the family only ever travels as a unit. Microsoft.AspNetCore.TestHost goes to 8.0.29 rather than the available 10.0.10: the test projects target net8.0, so staying in the 8.x servicing line is the bump that belongs here. DocumentFormat.OpenXml 3.1.1 -> 3.5.1 made WorkbookPart.Workbook nullable, which TreatWarningsAsErrors turned into a build failure in XlsxRowReader. It is now checked rather than assumed; the existing "contains no worksheets" error covers that case. Verified after a --no-incremental rebuild: Core 303, AspNetCore 159, UI (bUnit 2.9) 245, WebUi E2E (Playwright 1.61) 24 passed / 0 skipped with NEOREPORTS_REQUIRE_BROWSER=1, Jobs 34, Sources.Xlsx 32, Formats.Xlsx 7, Formats.Csv 5, Destinations.S3 3, Destinations.Local 14 — 0 failures. * chore(deps): use an explicit type on the OpenXml nullability guard Sonar's new-code maintainability gate is a debt ratio, and this PR changes exactly three lines of C#, so a single 'use explicit type instead of var' on one of them was enough to take the rating to 3. Sheet[]? is also the clearer read next to the null-conditional chain that produces it. * fix(sources): validate XlsxRowReader's arguments before the iterator starts `ReadRows` contains `yield`, so none of its body — including `ArgumentNullException.ThrowIfNull(stream)` — executed until the caller's first MoveNext. A null stream therefore surfaced from inside the enumeration, with a stack that no longer pointed at the call that passed it. Splitting the eager wrapper from the iterator makes the check fire where the mistake was made. This is what SonarCloud's new-code maintainability gate flagged on the dependency-bump PR. The line is pre-existing (63deea1, 2026-07-17) and Sonar counts it as new because the master baseline has been broken since the 50k-LOC free-tier cap hit on 2026-07-12 — but the finding itself is real, and the file already had to change here for the OpenXml nullability guard, so it is fixed rather than worked around. No test: XlsxRowReader is internal with no InternalsVisibleTo, and the public surface takes a file path or S3 config rather than a Stream, so the null path is not reachable from outside. The existing 32 tests pass unchanged, which is what confirms the split did not alter enumeration semantics.
This was referenced Aug 5, 2026
thiagoluga
added a commit
that referenced
this pull request
Aug 5, 2026
…running one (#272) The last item from the closed Dependabot set (#241-#251), held out of #266 and #267 because 9.5.2 -> 13.4.6 crosses four majors and reads like a framework migration. It is not one. All six AppHosts compile clean on net8.0 with no source changes, no NU warnings and no deprecation warnings: every API the samples use — AddPostgres, WithDataVolume, AddDatabase, AddProject<>, WithReference, WaitFor, WithExternalHttpEndpoints — survived intact. A clean build proves nothing about an orchestrator, so sample 10 was actually run, both ways the docs offer: `dotnet run --project .../AppHost` and the new `aspire run` CLI. Both bring the Postgres container up (~10-25s) and connect it to the session network. The documented workflow is unchanged; the CLI is an addition, not a replacement. Two real findings from running it: - The default PostgreSQL image moved from 17.6 to 18.3 with the Aspire version. Sample 10's header comment asserted "postgres:17", which was now false; it no longer names a tag it does not control. The READMEs' `docker run ... postgres:17` lines are untouched — those describe running Postgres yourself as an alternative to Aspire, and remain accurate. - `aspire run` writes an `aspire.config.json` pinned to whichever AppHost ran last. With six in this repo, committing it would tie everyone to one sample, so it is gitignored. Full solution rebuilt with --no-incremental; Core 303, Jobs 39, AspNetCore 159, UI 245.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github/codeql-action from 4 to 4.37.3.
Release notes
Sourced from github/codeql-action's releases.
... (truncated)
Changelog
Sourced from github/codeql-action's changelog.
Commits
e4fba86Merge pull request #4031 from github/update-v4.37.3-72f6a9da0fb50ab5Update changelog for v4.37.372f6a9dMerge pull request #4030 from github/mbg/fix/no-proxy3b5ee58Use defaultrequestoptions instead ofundefinedbfb6be4Merge pull request #4028 from github/mergeback/v4.37.2-to-main-e0647621526ab84Rebuildd6217b9Update changelog and version after v4.37.2e064762Merge pull request #4027 from github/update-v4.37.2-385bcdc5ae0faed8Add a couple of change notes73aad0eUpdate changelog for v4.37.2Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)