Add static/calico-enterprise/3.23/scripts/#2831
Merged
Merged
Conversation
The versioned static scripts dir was never created at the 3.23 version cut (only 3.14-3.22 and next existed), yet tmpScriptsURL points at /calico-enterprise/3.23, so switch-active-operator.sh 404s on production. Add the dir (switch-active-operator.sh, install-calico-windows.ps1) so it deploys ahead of the 3.23.1 release. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing Calico Enterprise 3.23 versioned static scripts directory so versioned docs that reference /calico-enterprise/3.23/scripts/... no longer 404 in production.
Changes:
- Add
static/calico-enterprise/3.23/scripts/switch-active-operator.sh. - Add
static/calico-enterprise/3.23/scripts/install-calico-windows.ps1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| static/calico-enterprise/3.23/scripts/switch-active-operator.sh | Introduces the 3.23 copy of the operator-switch helper script to match the expected versioned static URL path. |
| static/calico-enterprise/3.23/scripts/install-calico-windows.ps1 | Introduces the 3.23 copy of the Windows install script to populate the versioned static URL path. |
Comment on lines
+24
to
+27
| exit_code=0 | ||
| kubectl $@ 1> ${OUTPUT_TMP} | ||
| exit_code=$? | ||
| if [[ "${exit_code}" == "0" || "${exit_code}" == "" ]]; then |
| EOF | ||
| } | ||
|
|
||
| if kubectl get ns ${NEW_NAME} 2>&1 > /dev/null ; then |
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http:#www.apache.org/licenses/LICENSE-2.0 |
Comment on lines
+266
to
+268
| if (-Not $AutoCreateServiceAccountTokenSecret) { | ||
| throw "$SecretName service account token secret does not exist." | ||
| } else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
static/calico-enterprise/3.23/scripts/(switch-active-operator.sh,install-calico-windows.ps1), copied fromnext/.Why
The versioned static scripts dir was never created at the 3.23 version cut — only
3.14–3.22andnextexist understatic/calico-enterprise/. ButtmpScriptsURLin the 3.23variables.jspoints at/calico-enterprise/3.23, sodocs.tigera.io/calico-enterprise/3.23/scripts/switch-active-operator.sh404s on production.This targets
main(not the publication branch) so it deploys to production ahead of the 3.23.1 release — the release build's link check hits the live server, so the asset needs to be live first.🤖 Generated with Claude Code