refactor(lazy): update component type definitions to require 'x' prop#1910
Open
manudeli wants to merge 11 commits intofeat/stable-lazyfrom
Open
refactor(lazy): update component type definitions to require 'x' prop#1910manudeli wants to merge 11 commits intofeat/stable-lazyfrom
manudeli wants to merge 11 commits intofeat/stable-lazyfrom
Conversation
- Modified the `ImportCache` class to enforce that components must accept a prop `x` of type string. - Updated all relevant tests to pass the `x` prop when rendering lazy-loaded components. - Adjusted type definitions in `LazyOptions` to be more specific, enhancing type safety for lazy-loaded components.
People can be co-author:
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
…dering - Modified test assertions in `lazy.spec.tsx` to include the `x` prop in the rendered output of lazy-loaded components. - Ensured consistency in the expected output across multiple test cases, aligning with recent updates to the `ImportCache` class.
Contributor
|
Size Change: 0 B Total Size: 81.8 kB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/stable-lazy #1910 +/- ##
=================================================
Coverage 94.05% 94.05%
=================================================
Files 41 41
Lines 656 656
Branches 167 168 +1
=================================================
Hits 617 617
Misses 36 36
Partials 3 3
🚀 New features to boost your workflow:
|
manudeli
commented
Mar 3, 2026
Comment on lines
+3
to
+5
| interface LazyOptions<TComponentType extends ComponentType<any>> { | ||
| onSuccess?: ({ load }: { load: () => Promise<{ default: TComponentType }> }) => void | ||
| onError?: ({ error, load }: { error: unknown; load: () => Promise<{ default: TComponentType }> }) => void |
Member
Author
There was a problem hiding this comment.
@marshallku I don't know if we do type narrowing is better. but ComponentType is bad so I made suggestion
manudeli
force-pushed
the
feat/stable-lazy
branch
from
60e60ee to
1733815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we stablize
lazy, Could we think about this type narrowing? orPromise<void>is better for return type ofload?