Skip to content

refactor(lazy): update component type definitions to require 'x' prop #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manudeli wants to merge 11 commits into
base: feat/stable-lazy
Choose a base branch
from
Open

refactor(lazy): update component type definitions to require 'x' prop #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
48cf468
fix(react): Fix logics for setting storage keys
marshallku Feb 1, 2026
f5f813e
test(react): Verify logics for getting storage key
marshallku Feb 1, 2026
03b9132
fix(react): Prevent NaN to kill lazy silently
marshallku Feb 1, 2026
3239e8f
fix(react): Fix return type of onError
marshallku Feb 1, 2026
a5fd457
test(react): Fix typo in tc
marshallku Feb 1, 2026
8290ecf
docs(react): Remove experimental in lazy
marshallku Feb 1, 2026
b527806
Create soft-fishes-warn.md
manudeli Feb 3, 2026
4d9264c
fix(react): Use load itself instrad assigning toString
marshallku Mar 2, 2026
e037282
Merge branch 'main' into feat/stable-lazy
manudeli Mar 3, 2026
1bdf9bd
refactor(lazy): update component type definitions to require 'x' prop
manudeli Mar 3, 2026
79a4db6
fix(lazy): update test assertions to reflect changes in component ren…
manudeli Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/soft-fishes-warn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@suspensive/react": minor
---

feat(react): fix bugs in `lazy` and stabilize it
6 changes: 0 additions & 6 deletions docs/suspensive.org/src/content/en/docs/react/lazy.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@ import { Callout } from '@/components'

# lazy

<Callout type='experimental'>

`lazy` is an experimental feature, so this interface may change.

</Callout>

The `lazy` function is a wrapper around React's `lazy` function that provides callbacks for component loading success and failure. It allows you to execute custom logic when a component loads successfully or fails, providing better user experience and debugging capabilities.

### Preloading Components
Expand Down
6 changes: 0 additions & 6 deletions docs/suspensive.org/src/content/ko/docs/react/lazy.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@ import { Callout } from '@/components'

# lazy

<Callout type='experimental'>

`lazy`는 실험 기능이므로 이 인터페이스는 변경될 수 있습니다.

</Callout>

`lazy` 함수는 React의 `lazy` 함수를 래핑하여 컴포넌트 로딩 성공과 실패에 대한 콜백을 제공합니다. 컴포넌트가 성공적으로 로드되거나 실패할 때 사용자 정의 로직을 실행할 수 있어 더 나은 사용자 경험과 디버깅을 제공합니다.

### 컴포넌트 사전 로딩
Expand Down
Loading
Loading