test: check symlink refusal by errno instead of message - #732
Open
kudala-bharani wants to merge 2 commits into
Open
test: check symlink refusal by errno instead of message#732kudala-bharani wants to merge 2 commits into
kudala-bharani wants to merge 2 commits into
Conversation
kudala-bharani
marked this pull request as ready for review
September 11, 2026 01:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #731.
The lock is already rejected correctly on musl, but the test fails because musl says
Symbolic link loopand the regex expects different wording. Checkerrnoinstead, acceptingELOOPand the existing NetBSDEFTYPEcase. The real filesystem test and its capability checks stay in place; library behavior is unchanged.The reported wording fails before this change and passes after it in a local simulation. I also checked different error text, platforms without
EFTYPE, and an unrelatedEACCESerror that must still fail. These are simulations on macOS, not an actual musl run.Validation on macOS / Python 3.11.15:
tox run -e 3.11: 1,457 passed, 53 skipped; 100% line, branch, and diff coverage.yamlfmt, whose Go dependency download failed. No YAML files changed, and the full GitHub pre-commit check passes.Includes the required changelog fragment. GitHub's documentation build passes; the remaining Actions workflows need maintainer approval.