Skip to content

test: check symlink refusal by errno instead of message #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kudala-bharani wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

test: check symlink refusal by errno instead of message #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
422e2b1
test: check symlink refusal by errno instead of message
kudala-bharani Sep 11, 2026
e6b8033
test: use exception check and add portability news
kudala-bharani Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/732.packaging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Check symlink refusal by error code instead of error message so the test suite also passes with musl's wording.
3 changes: 2 additions & 1 deletion tests/test_filelock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import errno
import inspect
import logging
import os
Expand Down Expand Up @@ -2042,7 +2043,7 @@ def test_final_symlink_backend_refuses_to_lock(tmp_path: Path) -> None:
(tmp_path / "link").symlink_to(tmp_path / "target")
# Keeping the final symlink a distinct key is safe because the backend still refuses to lock through it. O_NOFOLLOW
# reports the refusal as ELOOP on Linux and macOS, and as EFTYPE ("inappropriate file type") on NetBSD.
with pytest.raises(OSError, match=r"Too many levels of symbolic links|symbolic link|Inappropriate file type"):
with pytest.raises(OSError, check=lambda exc: exc.errno in {errno.ELOOP, getattr(errno, "EFTYPE", errno.ELOOP)}):
FileLock(str(tmp_path / "link")).acquire()


Expand Down