Preserve real schematic component part metadata - #76
Open
Abse2001 wants to merge 1 commit into
Open
Conversation
Abse2001
force-pushed
the
codex/component-parameters
branch
from
August 31, 2026 21:22
62ab8dd to
b7a1081
Compare
Abse2001
changed the title
Abse2001
force-pushed
the
codex/component-parameters
branch
from
September 2, 2026 12:19
b7a1081 to
15887f5
Compare
Abse2001
changed the base branch from
main
to
codex/repro-component-parameters
September 2, 2026 12:19
Abse2001
force-pushed
the
codex/component-parameters
branch
from
September 2, 2026 12:41
15887f5 to
11dd1c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Stacked on the full-schematic reproduction PR. This change exports Circuit JSON
manufacturer_part_numberand supportedsupplier_part_numbersas hidden native Altium component parameter records.All populated metadata now survives the five complete schematic round trips. The full HERON systems snapshot changes from an 8-to-0 source/round-trip count to 8-to-8, making the semantic fix visible without replacing the real circuit with a focused fixture.
Verification
bun test tests/schematic-roundtrip01-nodemcu-esp12.test.ts tests/schematic-roundtrip02-heron-pay-ssm.test.ts tests/schematic-roundtrip03-simplefoc-mini.test.ts tests/schematic-roundtrip04-simplefoc-shield-v3.test.ts tests/schematic-roundtrip05-heron-systems-pcb.test.tsbun run formatbun run typecheckBase/reproduction PR: #97