Reproduce lost component metadata on real Altium schematics - #97
Open
Abse2001 wants to merge 2 commits into
Open
Reproduce lost component metadata on real Altium schematics#97Abse2001 wants to merge 2 commits into
Abse2001 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
This PR adds a regression boundary using five complete, pinned open-source Altium schematics. It does not change the exporter.
Four real schematics contain manufacturer and supplier part metadata: HERON PAY-SSM (12 components), SimpleFOC Mini (14), SimpleFOC Shield V3 (22), and HERON systems PCB (8). The current Circuit JSON → Altium → Circuit JSON round trip preserves zero of those populated component records. NodeMCU remains as a complete zero-metadata control.
The full-circuit snapshots are refreshed from the enriched source import, and the HERON systems snapshot includes visible source/round-trip count bars so the fix produces a reviewable snapshot difference.
The source fixtures, licenses, revisions, and hashes are documented in
references/README.md.Verification
bun test tests/schematic-roundtrip01-nodemcu-esp12.test.ts tests/schematic-roundtrip02-heron-pay-ssm.test.ts tests/schematic-roundtrip03-simplefoc-mini.test.ts tests/schematic-roundtrip04-simplefoc-shield-v3.test.ts tests/schematic-roundtrip05-heron-systems-pcb.test.tsbun run formatbun run typecheckStacked fix: #76