fix(editor): create_empty_map reports current_world and gains an opt-in open param - #133
Open
whalemenace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_empty_mapsaves a new UWorld but leaves the editor on whatever world was open, and nothing in the response says so. Agents chain create→populate and silently edit the wrong world — we've shipped actors into/Temp/Untitled_Nthis way, and on 0.22.0 the failure mode is quieter and worse: you edit whatever map happened to be open.Changes:
current_world(the editor world after the call) andopened, and the success message states explicitly that the open world is unchanged and how to open the new one.openparam (defaultfalse, no behavior change) loads the map after creation viaULevelEditorSubsystem::LoadLevel— same semantics aseditor::load_level, one call instead of the create/load pair every agent writes anyway.Verified live on 0.22.0: without
open,current_worldcorrectly reports the untouched world and the message warns; withopen=true, the editor lands on the new map and a follow-up world query confirms it.