Skip to content

refactor skills#14

Merged
pjcdawkins merged 13 commits intomainfrom
refactor-skills
Apr 21, 2026
Merged

refactor skills#14
pjcdawkins merged 13 commits intomainfrom
refactor-skills

Conversation

@ganeshdipdumbare
Copy link
Copy Markdown
Contributor

@ganeshdipdumbare ganeshdipdumbare commented Mar 24, 2026

  • Simplify skill content and provide a basis for further iteration

@ganeshdipdumbare ganeshdipdumbare marked this pull request as ready for review March 27, 2026 09:32
Copilot AI review requested due to automatic review settings March 27, 2026 09:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Upsun “skills” documentation by removing the legacy using-upsun skill content and introducing a new consolidated upsun skill with a smaller reference set, plus a minor Cursor plugin manifest tweak.

Changes:

  • Remove the plugins/upsun/skills/using-upsun/ skill and its reference docs.
  • Add a new plugins/upsun/skills/upsun/ skill entrypoint and a .upsun/config.yaml reference template page.
  • Minor formatting/punctuation update in the Cursor plugin manifest.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
plugins/upsun/skills/using-upsun/references/troubleshooting.md Deleted legacy troubleshooting reference doc.
plugins/upsun/skills/using-upsun/references/services-databases.md Deleted legacy services/databases reference doc.
plugins/upsun/skills/using-upsun/references/resources-scaling.md Deleted legacy resources/scaling reference doc.
plugins/upsun/skills/using-upsun/references/projects-organizations.md Deleted legacy projects/organizations reference doc.
plugins/upsun/skills/using-upsun/references/integration-variables.md Deleted legacy integrations/variables reference doc.
plugins/upsun/skills/using-upsun/references/environments.md Deleted legacy environments reference doc.
plugins/upsun/skills/using-upsun/references/development-tools.md Deleted legacy development tools reference doc.
plugins/upsun/skills/using-upsun/references/deployments.md Deleted legacy deployments reference doc.
plugins/upsun/skills/using-upsun/references/backups.md Deleted legacy backups reference doc.
plugins/upsun/skills/using-upsun/references/access-security.md Deleted legacy access/security reference doc.
plugins/upsun/skills/using-upsun/references/COMMAND-INDEX.md Deleted legacy command index reference doc.
plugins/upsun/skills/using-upsun/SKILL.md Deleted legacy using-upsun skill entrypoint.
plugins/upsun/skills/upsun/references/config.md Added .upsun/config.yaml reference templates and common type values.
plugins/upsun/skills/upsun/SKILL.md Added new consolidated Upsun skill entrypoint and workflows.
plugins/upsun/.cursor-plugin/plugin.json Minor manifest description punctuation change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
ganeshdipdumbare and others added 2 commits March 27, 2026 10:52
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Comment thread plugins/upsun/skills/upsun/references/config.md Outdated
Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
Comment thread plugins/upsun/skills/upsun/SKILL.md
Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated

## Safety rules

- `backup:restore` → create a safety backup of current state first, then confirm
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this means?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it as it was just in the old one but doesnt make sense.

Comment thread plugins/upsun/skills/upsun/SKILL.md Outdated
pjcdawkins added a commit that referenced this pull request Apr 9, 2026
SKILL.md:
- Add "How Upsun works" section covering core concepts (environments,
  build vs runtime, relationship env vars, .environment file)
- Fix deployment strategy: explain rolling vs stopstart with correct
  CLI flags (--deploy-strategy, --strategy)
- Improve env var section: env: prefix, --visible-build, project vs
  environment level
- Clarify backup trade-offs (standard consistency vs live downtime)
- Fix resources: container profiles, --resources-init, horizontal scaling
- Add source integration warning in Deploy workflow
- Add project:set-remote fallback in Step 1
- Remove disk from YAML config (resources are API-managed)
- Consolidate safety rules, remove --browser rule
- Address review comments from PR #14 (lines 178, 184, 188)

references/config.md:
- Add hook phases and .environment file documentation
- Add build.flavor: none and set -ex to all examples
- Consolidate near-duplicate YAML templates into one plus incremental
  "Adding services" snippet
- Add monorepo example with source.root
- Remove disk key from examples
- Add PHP-specific notes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pjcdawkins added a commit that referenced this pull request Apr 10, 2026
SKILL.md:
- Add "How Upsun works" section covering core concepts (environments,
  build vs runtime, relationship env vars, .environment file)
- Fix deployment strategy: explain rolling vs stopstart with correct
  CLI flags (--deploy-strategy, --strategy)
- Improve env var section: env: prefix, --visible-build, project vs
  environment level
- Clarify backup trade-offs (standard consistency vs live downtime)
- Fix resources: container profiles, --resources-init, horizontal scaling
- Add source integration warning in Deploy workflow
- Add project:set-remote fallback in Step 1
- Remove disk from YAML config (resources are API-managed)
- Consolidate safety rules, remove --browser rule
- Address review comments from PR #14 (lines 178, 184, 188)

references/config.md:
- Add hook phases and .environment file documentation
- Add build.flavor: none and set -ex to all examples
- Consolidate near-duplicate YAML templates into one plus incremental
  "Adding services" snippet
- Add monorepo example with source.root
- Remove disk key from examples
- Add PHP-specific notes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pjcdawkins added a commit that referenced this pull request Apr 10, 2026
SKILL.md:
- Add "How Upsun works" section covering core concepts (environments,
  build vs runtime, relationship env vars, .environment file)
- Fix deployment strategy: explain rolling vs stopstart with correct
  CLI flags (--deploy-strategy, --strategy)
- Improve env var section: env: prefix, --visible-build, project vs
  environment level
- Clarify backup trade-offs (standard consistency vs live downtime)
- Fix resources: container profiles, --resources-init, horizontal scaling
- Add source integration warning in Deploy workflow
- Add project:set-remote fallback in Step 1
- Remove disk from YAML config (resources are API-managed)
- Consolidate safety rules, remove --browser rule
- Address review comments from PR #14 (lines 178, 184, 188)

references/config.md:
- Add hook phases and .environment file documentation
- Add build.flavor: none and set -ex to all examples
- Consolidate near-duplicate YAML templates into one plus incremental
  "Adding services" snippet
- Add monorepo example with source.root
- Remove disk key from examples
- Add PHP-specific notes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pjcdawkins and others added 2 commits April 10, 2026 18:44
SKILL.md:
- Add "How Upsun works" section (environments, build vs runtime,
  relationship env vars, .environment file)
- Fix deployment strategy: rolling vs stopstart with correct CLI flags
- Improve env vars: env: prefix, --visible-build, project vs env level,
  auto-deploy behavior
- Clarify backup trade-offs (standard consistency vs live downtime)
- Fix resources: container profiles, --resources-init, horizontal scaling
- Add source integration warning in Deploy workflow
- Add project:set-remote fallback in Step 1
- Remove disk from YAML config (resources are API-managed)
- Broaden allowed-tools for read-only CLI commands
- Consolidate safety rules

references/config.md:
- Add hook phases and .environment file documentation
- Add build.flavor: none and set -ex to all examples
- Consolidate near-duplicate YAML templates
- Add monorepo example with source.root
- Remove disk key, add PHP-specific notes

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- upsun push works with source integrations (pushes to the source
  repo), but advanced git-push options are unavailable
- Clarify deploy vs redeploy: deploy is for staged changes,
  redeploy re-deploys current state (e.g. after project-level
  variable changes)
- Explain env:deploy:type manual for batching variable changes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Collaborator

@pjcdawkins pjcdawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting changes in #16

* fix: address review comments on skill refactor

- SKILL.md: switch allowed-tools frontmatter to comma separation so
  read-only patterns are parsed as separate entries.
- SKILL.md: correct deploy strategy default (stopstart, not rolling);
  rolling is opt-in for zero-downtime deploys.
- SKILL.md: fix env:deploy:type syntax — it's a command, not a property
  set via `set`.
- SKILL.md: clarify resources:set uses numeric CPU sizes; container
  profile (HIGH_CPU/BALANCED/HIGH_MEMORY/HIGHER_MEMORY) is set in
  .upsun/config.yaml, not via CLI.
- SKILL.md: update install commands to github.com/upsun/cli (CLI repo
  moved from platformsh/cli) and note Alpine/Debian/RPM packages.
- SKILL.md: qualify MCP tool names with mcp__upsun__ prefix.
- README.md: replace stale `using-upsun` references with `upsun`;
  simplify skill documentation section now that there is one reference
  file instead of eleven. Update install commands to upsun/cli.
- run-evals.yml: rename step to "Install upsun skill"; update CLI
  installer URL; drop redundant PATH export ($HOME/.local/bin is on
  PATH by default on ubuntu-latest runners).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Update plugins/upsun/skills/upsun/SKILL.md

Co-authored-by: Ganeshdip Dumbare <ganeshdip.dumbare@gmail.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-authored-by: Ganeshdip Dumbare <ganeshdip.dumbare@gmail.com>
@pjcdawkins pjcdawkins merged commit f121979 into main Apr 21, 2026
1 check passed
@pjcdawkins pjcdawkins deleted the refactor-skills branch April 21, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants