fix: address review comments on skill refactor#16
Merged
pjcdawkins merged 2 commits intorefactor-skillsfrom Apr 21, 2026
Merged
fix: address review comments on skill refactor#16pjcdawkins merged 2 commits intorefactor-skillsfrom
pjcdawkins merged 2 commits intorefactor-skillsfrom
Conversation
- SKILL.md: switch allowed-tools frontmatter to comma separation so read-only patterns are parsed as separate entries. - SKILL.md: correct deploy strategy default (stopstart, not rolling); rolling is opt-in for zero-downtime deploys. - SKILL.md: fix env:deploy:type syntax — it's a command, not a property set via `set`. - SKILL.md: clarify resources:set uses numeric CPU sizes; container profile (HIGH_CPU/BALANCED/HIGH_MEMORY/HIGHER_MEMORY) is set in .upsun/config.yaml, not via CLI. - SKILL.md: update install commands to github.com/upsun/cli (CLI repo moved from platformsh/cli) and note Alpine/Debian/RPM packages. - SKILL.md: qualify MCP tool names with mcp__upsun__ prefix. - README.md: replace stale `using-upsun` references with `upsun`; simplify skill documentation section now that there is one reference file instead of eleven. Update install commands to upsun/cli. - run-evals.yml: rename step to "Install upsun skill"; update CLI installer URL; drop redundant PATH export ($HOME/.local/bin is on PATH by default on ubuntu-latest runners). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Merged
ganeshdipdumbare
approved these changes
Apr 21, 2026
Co-authored-by: Ganeshdip Dumbare <ganeshdip.dumbare@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #14 (
refactor-skills). Addresses review comments on the skill refactor.Summary
allowed-toolsnow uses comma separation so the read-only patterns parse as separate entries instead of one big invalid spec. Pattern shapes kept narrow and read-only.upsun push/upsun deploydefault tostopstart, notrolling. Flipped the description;rollingis now described as opt-in for zero-downtime deploys.