Skip to content

bugfix for kintree stencil creation#319

Open
aleaverfay wants to merge 1 commit intomasterfrom
aleaverfay/small_kinforest_bugfix
Open

bugfix for kintree stencil creation#319
aleaverfay wants to merge 1 commit intomasterfrom
aleaverfay/small_kinforest_bugfix

Conversation

@aleaverfay
Copy link
Copy Markdown
Collaborator

Fixing a very small issue in the creation of scan orderings for leaf nodes in the FoldForest.

When processing the leaf-node exit-path assignment, (ie. j == n_conn +1), then whether an exit-path is available as one of the descendants does not matter, and thus it is usually preferable for CA to choose CB as its first child so it can build the side chain in the first path rather than e.g. C, where it would dead-end.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (2cc46cd) to head (4277b53).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   94.71%   94.35%   -0.37%     
==========================================
  Files         299      298       -1     
  Lines       20415    21598    +1183     
==========================================
+ Hits        19337    20378    +1041     
- Misses       1078     1220     +142     
Flag Coverage Δ
_shrug_Testing_CPU 89.91% <100.00%> (-0.01%) ⬇️
_shrug_Testing_CPU_debug_w_o_jit 92.30% <100.00%> (+0.12%) ⬆️
_shrug_Testing_CUDA 91.95% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant