Move BLIF model existence check in architecture from end of BLIF parse to corresponding blackbox definition line - #3257
Merged
Conversation
to point where corresponding blackbox model is read.
github-actions
Bot
added
VPR
AlexandreSinger
approved these changes
Aug 28, 2025
AlexandreSinger
left a comment
AlexandreSinger
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @haydar-c !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves BLIF model existence check in arch.xml from end of BLIF parse to point where corresponding blackbox model is read.
Old Behaviour
Throw an error if the blackbox BLIF model was not found in the architecture at the end of parsing. This gives the name of the mismatching blackbox model but was pointing the user to the end of BLIF file.
New Behaviour
Throw an error when we read that current model is a blackbox model and not found in architecture. This gives the name of the mismatching blackbox model and also points the user to line where current model is defined to be a blackbox model.
Related Issue
Some BLIF errors point to the wrong line number (end of file) - #3215
Note:
The throws checking the existence of a main model (we should have a non-blackbox) and checking the number of non-blackbox model (we should have only 1 non-blackbox model) are still pointing to the end of BLIF file. These makes sense to me to be at the end of file as design decisions but open to review.