Skip to content

Move BLIF model existence check in architecture from end of BLIF parse to corresponding blackbox definition line #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexandreSinger merged 1 commit into from
Aug 28, 2025
Merged

Move BLIF model existence check in architecture from end of BLIF parse to corresponding blackbox definition line #3257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions vpr/src/base/read_blif.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,12 @@ struct BlifAllocCallback : public blifparse::Callback {
}

void blackbox() override {
LogicalModelId arch_model_id = models_.get_model_by_name(curr_model().netlist_name());
if (!arch_model_id.is_valid()) {
vpr_throw(VPR_ERROR_BLIF_F, filename_.c_str(), lineno_, "Blackbox BLIF model '%s' has no equivalent architecture model.",
curr_model().netlist_name().c_str());
}

//We treat black-boxes as netlists during parsing so they should contain
//only inpads/outpads
for (const auto& blk_id : curr_model().blocks()) {
Expand Down Expand Up @@ -537,12 +543,6 @@ struct BlifAllocCallback : public blifparse::Callback {

bool verify_blackbox_model(AtomNetlist& blif_model) {
LogicalModelId arch_model_id = models_.get_model_by_name(blif_model.netlist_name());

if (!arch_model_id.is_valid()) {
vpr_throw(VPR_ERROR_BLIF_F, filename_.c_str(), lineno_, "BLIF model '%s' has no equivalent architecture model.",
blif_model.netlist_name().c_str());
}

const t_model& arch_model = models_.get_model(arch_model_id);

//Verify each port on the model
Expand Down