Open
Conversation
3 tasks
Contributor
|
Kidswiss
requested review from
a team,
TheBigLee,
mdnix,
mikeshootzz and
zugao
and removed request for
a team
Contributor
|
TheBigLee
reviewed
Apr 15, 2026
Member
TheBigLee
left a comment
TheBigLee
left a comment
There was a problem hiding this comment.
LGTM
Small nit: Ensure proper commit message and not just "WIP"
TheBigLee
approved these changes
Apr 15, 2026
Kidswiss
force-pushed
the
add/new_s3_implementation
branch
from
20c8676 to
936d2eb
Compare
This adds a new implementation for objectbuckets where no IAM is available. It allows to simply provision new buckets if credentials with sufficient permissions are supplied.
Contributor
|
Kidswiss
force-pushed
the
add/new_s3_implementation
branch
from
936d2eb to
69de5fa
Compare
Contributor
|
mikeshootzz
approved these changes
Apr 15, 2026
mdnix
reviewed
Apr 20, 2026
| BucketDeletionPolicy BucketDeletionPolicy `json:"bucketDeletionPolicy,omitempty"` | ||
|
|
||
| // Policy is a raw S3 bucket policy. | ||
| // Please consult https://min.io/docs/minio/linux/administration/identity-access-management/policy-based-access-control.html for more details about the policy. |
Contributor
Author
There was a problem hiding this comment.
We still use the minio client internally. So it should still be valid.
zugao
approved these changes
Apr 20, 2026
mdnix
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
/mergecomment.Component PR: vshn/component-appcat#1144