Open
Conversation
3 tasks
Kidswiss
force-pushed
the
appcat/642/add/new_s3_implementation
branch
from
fd6d896 to
ab183b0
Compare
Kidswiss
requested review from
a team,
Kidswiss,
TheBigLee,
mdnix,
mikeshootzz and
zugao
and removed request for
a team
Kidswiss
reviewed
Apr 15, 2026
| s3: | ||
| enabled: true | ||
| additionalProviderConfigs: | ||
| - name: switch |
Contributor
There was a problem hiding this comment.
Currently switch is just an entry to this additionalProviderConfigs. But I'm not sure if we want to make it more explicit?
Contributor
There was a problem hiding this comment.
I'm fine with this, especially because this should be a generic provider
mikeshootzz
approved these changes
Apr 15, 2026
mdnix
reviewed
Apr 20, 2026
| provider-s3: | ||
| registry: ghcr.io | ||
| repository: vshn/provider-s3 | ||
| tag: init |
Member
There was a problem hiding this comment.
needs to be updated with proper first release version
Kidswiss
force-pushed
the
appcat/642/add/new_s3_implementation
branch
2 times, most recently
from
8402b40 to
e87b62c
Compare
Kidswiss
reviewed
Apr 20, 2026
| minio: | ||
| enabled: false | ||
| switch: | ||
| enabled: true |
Contributor
There was a problem hiding this comment.
I'll change this to false again before merging, so we won't always deploy it for dev.
Kidswiss
force-pushed
the
appcat/642/add/new_s3_implementation
branch
from
e87b62c to
0ea6c46
Compare
zugao
reviewed
Apr 20, 2026
Kidswiss
force-pushed
the
appcat/642/add/new_s3_implementation
branch
from
0ea6c46 to
d1f625e
Compare
mdnix
approved these changes
Apr 21, 2026
Kidswiss
force-pushed
the
appcat/642/add/new_s3_implementation
branch
from
d1f625e to
174e0b9
Compare
Under the hood this leverages a generic s3 objectstorage implementation. So it can be extended easily in the future for other cloud providers.
Kidswiss
force-pushed
the
appcat/642/add/new_s3_implementation
branch
from
174e0b9 to
4674fda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
/mergecomment.Link: vshn/appcat#642