Conversation
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
I see that the build here is failing because of something to do with pear/http_request2. That dependency is no longer needed -- it was used by Phing 2, but is no longer required by Phing 3. You should be able to simply delete it and try again.
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Build is passing now! Do you mind adding the PHPUnit 11 rector rule and rearranging the ci.yaml phing_tasks as you just did for VuFindCode? I'll merge once this matches up with that one.
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @sambhavp96 -- one more small thing:
| }, | ||
| "require-dev": { | ||
| "friendsofphp/php-cs-fixer": "3.64.0", | ||
| "friendsofphp/php-cs-fixer": "3.89.2", |
There was a problem hiding this comment.
I see we're getting deprecation warnings about the rule names, which you fixed in the VuFindDate version of this PR. Do you mind adding that fix here as well?
There was a problem hiding this comment.
(In general, we should make sure all the projects have their configurations aligned with https://github.com/vufind-org/vufind/blob/dev/tests/vufind.php-cs-fixer.php -- the files should be mostly the same except for the selectors at the top).
2 participants
No description provided.