Skip to content

Upgrade Dependencies #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
demiankatz merged 3 commits into from
Nov 18, 2025
Merged

Upgrade Dependencies #32

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c24930a
Update Dependencies
sambhavp96 Nov 17, 2025
adae83e
Remove unused dependency
sambhavp96 Nov 17, 2025
2e6a3f0
Add phpunit rector rule
sambhavp96 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ jobs:
VUFIND_LOCAL_DIR: $GITHUB_WORKSPACE/local
strategy:
matrix:
php-version: ['8.1', '8.2', '8.3']
php-version: ['8.2', '8.3', '8.4']
include:
- php-version: 8.1
phing_tasks: "phpunitfast"
- php-version: 8.2
phing_tasks: "phpunitfast"
- php-version: 8.3
phing_tasks: "phpunitfast phpcs-console php-cs-fixer-dryrun phpstan-console rector-console"
- php-version: 8.4
phing_tasks: "phpunitfast"

steps:
- name: Setup PHP
Expand Down
17 changes: 8 additions & 9 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,23 @@
},
"config": {
"platform": {
"php": "8.1"
"php": "8.2"
}
},
"require": {
"php": ">=8.1",
"php": ">=8.2",
"laminas/laminas-http": ">=2.2"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "3.64.0",
"friendsofphp/php-cs-fixer": "3.89.2",
Copy link
Copy Markdown
Member

@demiankatz demiankatz Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we're getting deprecation warnings about the rule names, which you fixed in the VuFindDate version of this PR. Do you mind adding that fix here as well?

Copy link
Copy Markdown
Member

@demiankatz demiankatz Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(In general, we should make sure all the projects have their configurations aligned with https://github.com/vufind-org/vufind/blob/dev/tests/vufind.php-cs-fixer.php -- the files should be mostly the same except for the selectors at the top).

"guzzlehttp/guzzle": "^7.8.1",
"laminas/laminas-uri": ">=2.2",
"pear/http_request2": "2.6.0",
"phpmd/phpmd": "2.15.0",
"phpstan/phpstan": "1.12.7",
"phpunit/phpunit": "10.5.36",
"phing/phing": "3.0",
"squizlabs/php_codesniffer": "3.10.3",
"rector/rector": "^1.2"
"phpstan/phpstan": "2.1.32",
"phpunit/phpunit": "11.5.43",
"phing/phing": "3.1",
"squizlabs/php_codesniffer": "4.0.1",
"rector/rector": "2.2.8"
},
"autoload": {
"psr-0": {
Expand Down