fix: strict zip of items that fail on __eq__#135
Merged
vxgmichel merged 1 commit intovxgmichel:mainfrom Sep 21, 2025
Merged
Conversation
Some classes that could be in a stream (eg polars.DataFrame) fail on __eq__() with an object of a different type. Additionally, calling the custom __eq__ can be needlessly slow. Instead, use isinstance to compare against the sentinel value.
vthemelis
changed the title
zip of items that fail on __eq__zip of items that fail on __eq__
vthemelis
changed the title
zip of items that fail on __eq__ zip of items that fail on __eq__
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1157 1157
=========================================
Hits 1157 1157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@vthemelis Thanks a lot for the PR, lgtm :) Do you need a new release right away? |
vthemelis
added a commit
to vthemelis/aiostream
that referenced
this pull request
Sep 23, 2025
vxgmichel#135 got merged very quickly (thanks!) and I forgot to switch to simply using `is` for the comparison (which is faster and more appropriate).
vthemelis
added a commit
to vthemelis/aiostream
that referenced
this pull request
Sep 23, 2025
vxgmichel#135 got merged very quickly (thanks!) and I forgot to switch to simply using `is` for the comparison (which is faster and more appropriate).
vxgmichel
pushed a commit
that referenced
this pull request
Sep 24, 2025
Owner
|
Released in v0.7.1 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some classes that could be in a stream (eg
polars.DataFrame) fail on__eq__()with an object of a different type.Additionally, calling the custom
__eq__can be needlessly slow.Instead, use isinstance to compare against the sentinel value.